[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Bug#919743: RFS: rumur/2019.01.12-1 [ITP]



> On Jan 19, 2019, at 17:29, Adam Borowski <kilobyte@angband.pl> wrote:
> 
> On Fri, Jan 18, 2019 at 06:43:13PM -0800, Matthew Fernandez wrote:
>> * Package name    : rumur
>>  Version         : 2019.01.12-1
> 
>>  dget -x https://mentors.debian.net/debian/pool/main/r/rumur/rumur_2019.01.12-1.dsc
> 
>> Changes since the last upload:
>> 
>> Initial release. Closes #919220.
> 
> The package is marked as "UNRELEASED" -- ie, marked as not meant for
> uploading.  Generally, RFS bugs are requests for actual uploads, there's no
> need to file a bug if all you want is review of a WIP state.  I guess the
> marking was left accidentally…

Thanks for the review, Adam!

This was my own misunderstanding. I thought packages were intended to be marked “UNRELEASED” right up until when they were approved. I’ll fix that.

> The package fails to build:
> .----
> In file included from /<<PKGBUILDDIR>>/librumur/src/parse.cc:10:
> /<<PKGBUILDDIR>>/librumur/include/rumur/scanner.h:6:12: fatal error: FlexLexer.h: No such file or directory
>   #include <FlexLexer.h>
> `----
> This looks like missing build-dependency on libfl-dev.

I guess I didn’t notice this as I had something else installed that pulled in libfl-dev. Is there a page where I can see results from an attempted build of my uploaded package? Or maybe you built it yourself locally to discover this?

Reply to: