[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Bug#942085: RFS: hijra/0.4.1-2 [RC] -- Hijri Islamic Calendar converting functions for Python



On Sun, Nov 3, 2019 at 4:44 AM Jeremy Bicha <jbicha@debian.org> wrote:
>
> ‪On Sun, Nov 3, 2019 at 12:12 AM ‫أحمد المحمودي (Ahmed El-Mahmoudy)‬‎
> <aelmahmoudy@users.sourceforge.net> wrote:‬
> > On Sat, Nov 02, 2019 at 05:27:35AM -0400, Jeremy Bicha wrote:
> > > In this case, I see the new tag has already been pushed so I wouldn't
> > > worry about it here.
> >
> > Since you didn't upload yet, I made a couple of changes and pushed a
> > new tag.
>
> You have pushed 2 or 3 versions of the "0.4.1-2" tag. Please don't do
> this next time. If someone has already pulled a git tag, git by
> default won't change that tag. Next time, you should just bump the
> debian/changelog and tag to "0.4.1-3", then "0.4.1-4". It's better to
> "skip" numbers in your debian/changelog than have people who have
> checked out your git repo with different tagged commits.
>
> Your gnome-shell-extension-hijra package says that it depends on
> gnome-shell (>= 3.2), gnome-shell (<< 3.31) . Since gnome-shell 3.34
> is in Testing, hijra will not migrate to Testing with that dependency.
> Please check whether your extension works with gnome-shell from
> Testing. If so, you can bump that dependency. You might be able to
> remove the upper limit on the dependency, but someone will need to
> check whether the extension works with the new gnome-shell version
> every 6 months.
>
> I am going to delay uploading until the gnome-shell dependency issue is fixed.

Your python3-hijra package is uninstallable:

Setting up python3-hijra (0.4.1-2) ...
Sorry: TabError: inconsistent use of tabs and spaces in indentation
(HijriCal.py, line 83)
dpkg: error processing package python3-hijra (--configure):
 installed python3-hijra package post-installation script subprocess
returned error exit status 1
dpkg: dependency problems prevent configuration of hijra-applet:
 hijra-applet depends on python3-hijra (= 0.4.1-2); however:
  Package python3-hijra is not configured yet.


Thank you for adding me to the Salsa team as a Developer. I tried
pushing a minor change to othman's packaging repo, but the repo
settings are that only Maintainers can push to the master branch.
Please allow Developers to push there too.

I think there is a good chance that the hijra gnome-shell extension
will work with the gnome-shell version in Testing. If so, please drop
the upper gnome-shell dependency limit so that the gnome-shell
extension will be installable.

Thanks,
Jeremy Bicha


Reply to: