Bug#941569: RFS: sentencepiece/0.1.83+dfsg-1 [ITP] -- Unsupervised text tokenizer for Neural Network-based text generation
Hi,
Thank you for reviewing. It is very helpful.
On Wed, 2 Oct 2019 23:13:45 +0200 Adam Borowski <kilobyte@angband.pl> wrote:
> On Wed, Oct 02, 2019 at 02:52:23PM +0900, Kentaro Hayashi wrote:
> > * Package name : sentencepiece
> > Version : 0.1.83+dfsg-1
> > Upstream Author : Google Inc.
> > * URL : https://github.com/google/sentencepiece
snip
> Hi!
> The runtime library package (ie, libsentencepiece) should have soname
> appended. This might be not a big change, but amending this later would
> require a trip through NEW, thus let's get it right from the start.
>
> The watch file also should mangle the version, to include +dfsg.
>
> It is inappropriate to make lintian overrides for real bugs (like a lack of
> manpage). You are not required to fix everything immediately -- heck, there
> are many bugs that don't get fixed ever -- but that's not a valid use for
> overrides. They're for false positives.
>
> But overall, the package seems almost ready.
I could find a sponsor personally (@knok) and a collabolator(@tsuchm),
so I'll fix above issues with them. Thanks!!!
Regards,
Reply to: