Bug#932438: RFS: irqbalance/1.6.0-1 [ITA] -- Daemon to balance interrupts for SMP systems
Paride Legovini wrote on 21/07/2019:
> Dmitry Bogatov wrote on 20/07/2019:
>> * current runscript does not respect ONESHOT option. It can be fixed
>> with something like
>>
>> #!/bin/sh
>> . /etc/default/irqbalance
>> if [ -n "${ONESHOT:-}" ] ; then
>> irqbalance --oneshot
>> sv down irqbalance
>> else
>> exec irqbalance --foreground
>> fi
>>
>> but it would be quite unnatural. I think proper solution would be
>> separation of /etc/init.d/irqbalance and /etc/init.d/irqbalance-oneshot.
>
> I agree calling `sv down` from the runscript is ugly, on the other side
> I don't really like the idea of having two sets of init scripts for
> three init systems. Moreover while dh_installsystemd and dh_installinit
> have a --no-enable option, dh_unit does not, requiring some manual
> (hacky) handling.
Looks like "sv once" is not really meant for "oneshot" services, and
runit seems to be lacking a proper "oneshot", see:
https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=787363
(a bug you know). What about explicitly not supporting the "oneshot"
mode in runit, documenting the lack of support?
Paride
Reply to: