--- Begin Message ---
On 2019-07-17 12:48, Sergey B Kirpichev wrote:
On Wed, Jul 17, 2019 at 06:56:53AM +0200, Sebastiaan Couwenberg wrote:
Please push the buster-backports branch to Salsa, I'll take it from
there.
Pushed too.
Consider adding debian/gbp.conf to use pristine-tar and the appropriate
debian-branch by default, i.e.:
$ cat debian/gbp.conf
[DEFAULT]
# The default name for the Debian branch is "master".
# Change it if the name is different (for instance, "debian/unstable").
debian-branch = buster-backports
# Always use pristine-tar.
pristine-tar = True
[buildpackage]
pbuilder-options = --source-only-changes
This will make git-buildpackage not complain about the branch not being
master, and will use pristine-tar by default. Not need to specify all
these options when using gbp buildpackage or import-orig.
The pbuilder-options ensure that a _source.changes file is also
generated for source-only uploads (for migration to testing) while also
have _amd64.changes available (for initial uploads to NEW).
The branch should also be set (when not using the default branch) in the
Vcs-Git URL in debian/control:
Vcs-Git: https://salsa.debian.org/sk-guest/monit.git -b
buster-backports
This makes debcheckout use the appropriate branch.
There are also several easy to fix lintian issues:
P: monit source: file-contains-trailing-whitespace debian/changelog
(line 822)
P: monit source: file-contains-trailing-whitespace debian/changelog
(line 879)
P: monit source: file-contains-trailing-whitespace debian/changelog
(line 891)
P: monit source: file-contains-trailing-whitespace debian/changelog
(line 897)
P: monit source: file-contains-trailing-whitespace debian/changelog
(line 919)
P: monit source: file-contains-trailing-whitespace debian/changelog
(line 934)
P: monit source: file-contains-trailing-whitespace debian/changelog
(line 950)
P: monit source: file-contains-trailing-whitespace debian/changelog
(line 993)
P: monit source: insecure-copyright-format-uri
http://www.debian.org/doc/packaging-manuals/copyright-format/1.0/
I: monit source: testsuite-autopkgtest-missing
These are not blockers for sponsoring the upload, but will improve the
package in future uploads.
The package has been uploaded, but please consider addressing the above
issues in unstable at least.
Kind Regards,
Bas
--- End Message ---