Bug#930952: RFS: libagentcrypt/1.0.5-2 [ITP] -- symmetric encryption with SSH Agent

[Adam Borowski <kilobyte@angband.pl>]

On Sun, Jun 23, 2019 at 02:24:42PM +0200, Nicola Di Lieto wrote:
> * Package name    : libagentcrypt
>  Version         : 1.0.5-2
>  Upstream Author : Nicola Di Lieto <nicola.dilieto@gmail.com>
> * URL             : https://github.com/ndilieto/libagentcrypt

> It builds those binary packages:
> 
> libagentcrypt0 - Symmetric encryption with SSH Agent
> libagentcrypt-dev - Symmetric encryption with SSH Agent - headers
> libagentcrypt-bin - Symmetric encryption with SSH Agent - command line utility

Hi!
How do I use this program?  According to my reading of the man page,
the following should work:

[/tmp]$ echo meow >foo
[/tmp]$ agentcrypt foo
agentcrypt: failed to encrypt foo: Invalid argument
[/tmp]$ agentcrypt -v foo
agentcrypt: encrypting foo to foo.acb in binary mode
agentcrypt: failed to encrypt foo: Invalid argument

The ssh agent is running, and I can ssh normally.


You can run lintian to automate the bulk of reviewers' work.
Here, it says:
W: libagentcrypt-dev: manpage-has-bad-whatis-entry usr/share/man/man3/libagentcrypt.h.3.gz
W: libagentcrypt-dev: pkg-config-references-unknown-shared-library usr/lib/x86_64-linux-gnu/pkgconfig/libagentcrypt.pc -lsodium (line 26)
E: libagentcrypt0: repeated-trigger-name activate-noawait ldconfig (line 3) vs activate-noawait ldconfig (line 1)

repeated-trigger-name is because both you and dh add the same trigger; you
can remove it.

There's no reason for user programs to link with libsodium:
[~]$ ldd /usr/lib/x86_64-linux-gnu/libagentcrypt.so.0
	linux-vdso.so.1 (0x00007fff1b6ab000)
	libgtk3-nocsd.so.0 => /usr/lib/x86_64-linux-gnu/libgtk3-nocsd.so.0 (0x00007f5d7789e000)
	libsodium.so.23 => /usr/lib/x86_64-linux-gnu/libsodium.so.23 (0x00007f5d77847000)
	libc.so.6 => /lib/x86_64-linux-gnu/libc.so.6 (0x00007f5d77686000)
	libdl.so.2 => /lib/x86_64-linux-gnu/libdl.so.2 (0x00007f5d77681000)
	libpthread.so.0 => /lib/x86_64-linux-gnu/libpthread.so.0 (0x00007f5d77660000)
	/lib64/ld-linux-x86-64.so.2 (0x00007f5d77ad0000)
any program that uses your library will recursively pull in libsodium
via the loader; if you recompile against a different backend or even
a different soversion of libsodium that won't affect the programs.


Meow!
-- 
⢀⣴⠾⠻⢶⣦⠀ I've read an article about how lively happy music boosts
⣾⠁⢰⠒⠀⣿⡁ productivity.  You can read it, too, you just need the
⢿⡄⠘⠷⠚⠋⠀ right music while doing so.  I recommend Skepticism
⠈⠳⣄⠀⠀⠀⠀ (funeral doom metal).