[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Bug#929467: RFS: tfortune-1.0.0 [ITP]



On Sat, Jun 01, 2019 at 11:17:53PM +0200, Andre Noll wrote:
> Adam, do you want me to provide v3 with debian/rules changed to
> something like the above?

v2 still suffers from the non-standard perms on usr/ and so on, thus I guess
it'd be simpler to move to the dh workflow rather than to fix what you
currently have.

It's by no means mandatory, but our newly elected Dear Leader is waging a
campaign to make it strongly recommended, especially for new packages.  I
quite see why.  And I for one prefer packages where a reviewer doesn't have
to fire up the brain to comprehend what's being done. :)

(But again, it's no cdbs nor waf -- I'd gladly review either approach.)

> Note, however, that building with the simple debian/rules file prints a
> warning because dh_auto_configure seems to add --disable-silent-rules,
> --disable-maintainer-mode and --disable-dependency-tracking to the
> configure command line, which tfortune's configure doesn't know.

Yeah, it assumes autotools' quirks.  If that's a concern, you do:

override_dh_auto_configure:
	dh_auto_configure --some --params

or:
override_dh_auto_configure:
	./configure --foo --bar

The man page says:

# This is intended to work for about 90% of packages.  If it doesn't work,
# you're encouraged to skip using dh_auto_configure at all, and just run
# ./configure or its equivalent manually.

> This seems to be a common problem. One solution is to call configure
> directly, as recommended in the dh_auto_configure man page. Another way
> to avoid the warning is to provide noop-stubs for the three options
> in configure.ac. I'd prefer to call configure directly because this
> is a bit simpler and touches only debian/rules. Opinions anybody?

Either way would work.


Meow!
-- 
⢀⣴⠾⠻⢶⣦⠀ Latin:   meow 4 characters, 4 columns,  4 bytes
⣾⠁⢠⠒⠀⣿⡁ Greek:   μεου 4 characters, 4 columns,  8 bytes
⢿⡄⠘⠷⠚⠋  Runes:   ᛗᛖᛟᚹ 4 characters, 4 columns, 12 bytes
⠈⠳⣄⠀⠀⠀⠀ Chinese: 喵   1 character,  2 columns,  3 bytes <-- best!


Reply to: