Hi Sébastien, Thanks for taking the time to review the package. On 4/17/19 2:55 PM, Sébastien Villemot wrote:
— The autopkgtest does not work. I get: autopkgtest [14:48:10]: test cuba: [----------------------- make: *** No rule to make target 'check'. Stop. autopkgtest [14:48:11]: test cuba: -----------------------] autopkgtest [14:48:11]: test cuba: - - - - - - - - - - results - - - - - - - - - - cuba FAIL non-zero exit status 2
I misunderstood how autopkgtest works. Now the test is a simple compile, link and run check. I checked that it succeeds adding the B20autopkgtest hook to pbuilder.
— I think there is a typo in the long description of libcuba4. It talks about “libuba4-dev”, while I guess you meant “libcuba-dev”.
Fixed, thanks.
— In debian/changelog, you should keep the three former entries corresponding to the previous version of the package. Keeping the whole history of the package will facilitate the long-term maintenance. See https://tracker.debian.org/media/packages/c/cuba/changelog-3.0%2B20111124-2
That's a doubt I still had, thanks for bringing it up. I added back the old entries and more details about differences with the old package.
Best, Francesco