Bug#925911: RFS: lopsub-1.0.2 [ITP]

[Adam Borowski <kilobyte@angband.pl>]

(Sorry for slow response time.)

On Sat, Apr 06, 2019 at 09:52:53PM +0200, Andre Noll wrote:
> > > I see a static library installed by the package.  Those shouldn't generally
> > > be used unless you're doing something special -- static linking makes
> > > security and bugfix updates extremely tedious.  Libraries should also be
> > > split into separate binary packages, with lib${name}dev providing
> > > development files while lib${name}${so} the runtime lib.

I'm afraid that the shared library doesn't work: liblopsub1 in /usr/lib
has nothing but an infinite symlink loop from liblopsub.so.unnamed_version
back to itself.

Besides a proper soname, the file should also go to a multiarch dir (ie,
/usr/lib/x86_64-linux-gnu on amd64, /usr/lib/aarch64-linux-gnu on arm64,
etc -- most build systems get it right without your action).

Also, I wonder why you include the soname in the -dev package's name. 
That's allowed but usually not what you want -- an ABI break will also
require changing every depending package instead of a simple recompile.
Unless you change the API every time there's a soname bump, it'd be
better to have the -dev package be unversioned.  But this is up to you.


Meow!
-- 
⢀⣴⠾⠻⢶⣦⠀
⣾⠁⢠⠒⠀⣿⡁ Did ya know that typing "test -j8" instead of "ctest -j8"
⢿⡄⠘⠷⠚⠋⠀ will make your testsuite pass much faster, and fix bugs?
⠈⠳⣄⠀⠀⠀⠀