Hello Pedro, Am 08.03.19 um 02:49 schrieb Pedro Pena: > Hello Markus, > > I found an online appstream generator that helped me create the appstream file. > > I built the package without any errors. and just uploaded it. > > I installed the package hoping to see the appstream data rendered in > the package manager but I guess it only displays info from the > control file when it isn't an official debian package. > > Please let me know if I'm missing anything. I think we are very close now to upload infinitetux. I have attached two patches. The first one will change the installation directory to /usr/share/games. The other one will use the --release flag instead of -source and -target. This prevents an error when using OpenJDK 8 to run the game. Please remove the executable bit from all java and resource files. chmod a-x. Currently the game creates an infinitetux-data directory in the user's home directory where it saves tiles.dat. This directory should be hidden and renamed to .infinitetux. You could also consider to follow the XDG specification. https://specifications.freedesktop.org/basedir-spec/basedir-spec-latest.html Last but not least, please add some VCS links to debian/control and change the maintainer field to Debian Games Team <pkg-games-devel@lists.alioth.debian.org> and add yourself as Uploader. Uploaders: qbancoffee <qbancoffee@yahoo.com> This way it is easier for others to make changes to the package and keep it in good shape. Otherwise the rest looks good to me. I will import the next revision into our Git repository. You can ask for access here: https://salsa.debian.org/games-team Cheers, Markus
From 691369953345d31a88636c2f0f2aabdf0bb126f3 Mon Sep 17 00:00:00 2001 From: Markus Koschany <apo@debian.org> Date: Sun, 10 Mar 2019 15:22:56 +0100 Subject: [PATCH 1/2] Install infinitetux.jar into /usr/share/games. --- debian/infinitetux.links | 2 +- debian/install | 2 +- debian/rules | 5 +++-- 3 files changed, 5 insertions(+), 4 deletions(-) diff --git a/debian/infinitetux.links b/debian/infinitetux.links index 7c61489..6a78453 100644 --- a/debian/infinitetux.links +++ b/debian/infinitetux.links @@ -1 +1 @@ -/usr/share/infinitetux/infinitetux.jar /usr/games/infinitetux +/usr/share/games/infinitetux/infinitetux.jar /usr/games/infinitetux diff --git a/debian/install b/debian/install index b317498..2f17a48 100644 --- a/debian/install +++ b/debian/install @@ -1,4 +1,4 @@ -../infinitetux.jar usr/share/infinitetux +infinitetux.jar usr/share/games/infinitetux infinitetux.appdata.xml usr/share/metainfo infinitetux.desktop usr/share/applications infinitetux.png usr/share/icons/hicolor/256x256/apps diff --git a/debian/rules b/debian/rules index 091190d..7a62756 100755 --- a/debian/rules +++ b/debian/rules @@ -5,8 +5,9 @@ override_dh_auto_build: JAVA_HOME=/usr/lib/jvm/default-java jh_build --no-javadoc --javacopts="-source 1.8 -target 1.8" \ - --main=com.mojang.mario.FullScreenFrameLauncher ../infinitetux.jar src + --main=com.mojang.mario.FullScreenFrameLauncher infinitetux.jar src override_dh_install: - jar uf ../infinitetux.jar -C src/main/resources . + jar uf infinitetux.jar -C src/main/resources . dh_install + -- 2.20.1
From 824bce75f919d57e0019e3e842074583caaeeecc Mon Sep 17 00:00:00 2001 From: Markus Koschany <apo@debian.org> Date: Sun, 10 Mar 2019 15:29:58 +0100 Subject: [PATCH 2/2] Use -release 8 option. --- debian/rules | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/debian/rules b/debian/rules index 7a62756..90c82a9 100755 --- a/debian/rules +++ b/debian/rules @@ -4,7 +4,7 @@ override_dh_auto_build: JAVA_HOME=/usr/lib/jvm/default-java - jh_build --no-javadoc --javacopts="-source 1.8 -target 1.8" \ + jh_build --no-javadoc --javacopts="--release 8" \ --main=com.mojang.mario.FullScreenFrameLauncher infinitetux.jar src override_dh_install: -- 2.20.1
Attachment:
signature.asc
Description: OpenPGP digital signature