Bug#920039: RFS: brightness-controller/2.2.3 [ITP]
On Tue, Jan 22, 2019 at 01:41:49AM +0530, Archisman Panigrahi wrote:
> * Package name : brightness-controller
> Version : 2.2.3
> brightness-controller - Easily adjust your display brightness
Hi!
Why is this a native package if it's in no way specific to Debian only?
The package installs no useful executables,
/usr/share/brightness-controller/init.py has no x bit and its only contents
is "/usr/share/brightness-controller/init.py\n".
I wonder why the source package has a FHS-ish layout. This might be
acceptable (but certainly atypical), but suggests something wrong is going
on.
At least some Python files have been generated but don't get regenerated
during the build.
The copyright file lacks at least yourself. That's ok only if you're doing
the packaging as a part of your work duties, but I have doubts that "Amit
Seal Ami <amitsealami@gmail.com>" is your employer.
The package's description is not supposed to talk about license, the
upstream's github nor how to report bugs. Likewise, it's not a place to
ask for review.
It's probably a bad idea to use Python [2] in the packaging of a new
program. While Python 2 is still supported for Buster, it'll be dropped
early in the next release cycle.
There's no man page.
Meow!
--
⢀⣴⠾⠻⢶⣦⠀
⣾⠁⢠⠒⠀⣿⡁ Remember, the S in "IoT" stands for Security, while P stands
⢿⡄⠘⠷⠚⠋⠀ for Privacy.
⠈⠳⣄⠀⠀⠀⠀
Reply to: