[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Bug#908626: RFS: ukui-greeter/1.1.4-1 [ITP]



X-Debbugs-CC: jianfengli@ubuntukylin.com
Control: tag -1 + moreinfo

Hi handsome_feng!

I'm glad to see that you are continue pushing UbuntuKylin's software into 
upstream Debian. Here are some overall reviews:

* For upstream developer: No need to pre-compress man page into .gz file. 
Debian packaging system (debhelper, or to be more concrete, dh_compress) will 
handle it for you.

* Now that ukui-greeter's packaging is maintained in the ukylin team under 
Debian Salsa platform, Vcs-Git should *NOT* point to upstream GitHub project 
-- it should point to the git repo under your Salsa team. Please also fix this 
problem for other ukui-related packages.

* You should almost *NEVER* explicitly write library packages into binary 
package's dependency list. Explicitly writing it also made your package unable 
to be binNMU-ed. In fact, such library dependency will be automatcially 
deduced by Debian's build system. See dh_shlibdeps(1) for more information.

* You missed qt5-qmake as build-dependency. Without this package, ukui-greeter 
will not be able to build successfully since qmake cannot be found anywhere.

Please fix those problem mentioned above. If you have any question, don't 
hesitate to ask me or seek help on debian-mentors. After fixing those 
problems, I'd be delighted to sponsor your package.

--
Regards,
Boyuan Yang


在 2018年9月11日星期二 EDT 下午10:32:01,您写道:
> Package: sponsorship-requests
> Severity: normal
> 
> Package: sponsorship-requests
>   Severity: wishlist
> 
>   Dear mentors,
> 
>   I am looking for a sponsor for my package "ukui-greeter"
> 
>  * Package name    : ukui-greeter
>    Version         : 1.1.4-1
>    Upstream Author : yang hao <yanghao@kylinos.cn>
>  * URL             : https://salsa.debian.org/kylin-team/ukui-greeter
>  * License         : GPL-2+
>    Section         : x11
> 
>   It builds those binary packages:
> 
>     ukui-greeter - Lightdm greeter for UKUI
> 
>   To access further information about this package, please visit the
> following URL:
> 
>   https://mentors.debian.net/package/ukui-greeter
> 
> 
>   Alternatively, one can download the package with dget using this command:
> 
>     dget -x https://mentors.debian.net/debian/pool/main/u/ukui-greeter/ukui-> greeter_1.1.4-1.dsc
> 
>   More information about ukui-greeter can be obtained from
> https://github.com:ukui.
> 
> 
>   Regards,
>    handsome_feng


Attachment: signature.asc
Description: This is a digitally signed message part.


Reply to: