Bug#907826: RFS: gnomint/1.3.0-1 [QA] [RC]

[Andreas Henriksson <andreas@fatal.se>]

Hello Yavor Doganov,

Thanks for working on improving this package. Please see comments below
(inline).

On Sun, Sep 02, 2018 at 07:41:18PM +0300, Yavor Doganov wrote:
[...]
> I'm looking for a sponsor for a QA upload of "gnomint".
> 
>  * Package name    : gnomint
>    Version         : 1.3.0-1
[...]
> Changes since the last upload:
> 
>   * QA upload.
>   * New upstream release.
>   * debian/compat: Set to 11.
>   * debian/control: Run wrap-and-sort -ast.
>     (Build-Depends): Bump debhelper requirement to match the compat level.
>     Remove autotools-dev and libgconf2-dev.
>     (Standards-Version): Claim compliance with 4.2.1 as of this release.
>   * debian/rules: Enable all hardening.  Remove --with autotools_dev.
>     (override_dh_auto_install): Remove gconf schemas stuff.
>   * debian/patches/682432.patch: Refresh.
>   * debian/patches/02-cflags.patch: Remove configure hunk; refresh and
>     remove -Werror.  Fix typo in the patch description.
>   * debian/patches/01-ldd.patch:
>   * debian/patches/10_gnutlsv3.diff: Delete, fixed upstream.
>   * debian/patches/fix-autoreconf.patch: New, fix autoreconf failure.
>   * debian/patches/gsettings-port.patch: New, migrate from GConf to
>     GSettings (Closes: #885817).  I believe the switch to GSettings also
>     closes: #631768 which was probably due to the fact that GConf does not
>     apply changes atomically.

This patch seems to include a conversion file to migrate the existing
data/settings over from gconf2 to gsettings database, however the
'gsettings-data-convert' tool is part of the 'gconf2' package
but there's no dependency from gnomint against gconf2 so the conversion
won't happen unless the user already has gconf2 installed (which
is becoming less and less likely).

With gsettings migration I guess you feel it's unwelcome to have
a dependency on gconf2 remaining in buster, but for data conversion
the dependency needs to remain until gsettings conversion has shipped
in one stable debian release (as a minimum).

>   * debian/patches/export-private-key-crash.patch: New, fix crash when
>     exporting the private key (Closes: #855200).  Thanks to Karl E.
>     Jorgensen for the report.
>   * debian/patches/desktop-file.patch: New, fix some lintian complaints.
>   * debian/patches/spelling-errors.patch: New, self-explanatory.
>   * debian/patches/series: Update.
>   * debian/watch: New file.
>   * debian/pixmaps/gnomint.xpm:
>   * debian/gnomint.menu:
>   * debian/gnomint.install: Delete.

I guess you mean 'Delete' applies to all three above? Maybe would
have been better to write them under the same bullet point.
(Also I'm not sure about separating the changelog on a per-file
basis, rather than on a per-change basis but I guess that's related
to personal taste and different people do it differently.)

>   * debian/copyright: Declare format.
> 

Regards,
Andreas Henriksson