Bug#896970: RFS: odp/1.19.0.0-1 [ITP]
Hello,
I have updated odp & odp-dpdk packages on mentors.d.n.
2018-05-06 3:56 GMT+03:00 Dmitry Eremin-Solenikov <dbaryshkov@gmail.com>:
> I will make my next upload use alternatives, thank you.
This upload uses alternatives to select ODP library to be used.
>> * move all the executables to /usr/bin. Their name starts with odp_, so
>> I don't expect them to pollute the public name space. Putting these
>> test programs in a private directory just makes it hard to find and
>> use them.
>
> This looks logical to me. I will move some (usefull) programs to /usr/bin
> and will drop the rest of them.
I have moved several executables to /usr/bin and removed the rest of them.
This upload does not have manpages for those binaries, I will fix that in
the next upload.
>>> > 11. Why is dh_auto_test overrode to empty?
>>>
>>> We had issues with make check before, they interacted strangely with
>>> build environment, that is why it is disabled for now. I plan to
>>> reenable it later.
>>
>> How strange is it? And what happend during the test?
>>
>> As per policy, network access during the build is not availble. If this
>> is the cause of test problem, we can omit the test part. However, we
>> should still write the tests in the override_dh_auto_test target, if our
>> user want to test it somehow.
>
> Some of the validation scripts are trying to create/remove network
> interfaces.
>
>> override_dh_auto_test:
>> -test_binary
>>
>> This should be ok.
>
> Ack
This is not fixed yet. Also will be fixed in the next upload.
Could you please review alternatives system, so that I can be sure that
I've used them correctly?
--
With best wishes
Dmitry
Reply to: