Bug#896714: Bug#894865: RFS: cavestory-nx/1.0.0-1 [ITP] -- NXEngine is a Cave Story game engine clone

[Tobias Frost <tobi@debian.org>]

Control: tags -1 wontfix

Hi Carlos,

currently short on time, but the below copyright issue needs immediate attention.

On Sun, May 06, 2018 at 05:58:10PM -0300, Carlos Donizete Froes wrote:
> > Hi Carlos,

(snip) 
> 
> > Others / ITP related / Project related. 
> > - there is a Readme.txt on the game assests stating that this is free
> >   software but there is no license text attached. As "free" is ambiguous,
> >   Can you please elaborate the source where you've got the data from?
> >   I've only found some data file at the original authors website, but it
> >   is lacking this Readme.txt. (I can't find the rationale why you say it
> >   is Public Domain)
> 
> I added this readme.txt where copied the license comments in the official forum
> of the game.

Thanks. However, I after checking the post [1],
 - this seems to be a fan-forum, not the "official" one.
 - there is nothing noted in the post that the game assets are under a free
   license, nor that it is in Public Domain.
 - Contraire, the thread explains well that the copyright is "all rights reserved"
   by default, and the original author "Pixel himself is historically very
   closed-source/distribution-without-modification biased so it'd be an uphill
   battle either way."

IANAL, but IMHO _this_ is a high legal risk for the Debian project.  Please
remove cavestory-nx from all Debian servers immediatly, at least until this is
solved. (Also Set the salsa repository to private)

[1]https://www.cavestory.org/forums/threads/cave-story-freeware-license.13817/

> If there is no need to document this, I will remove it from the 'data' directory
> and d/copyright.

d/copyright needs to document everything copyright related!

> > - as you've seem have to forked from nxegine-evo [1], can you go a bit
> >   into the reasons of your fork. As far as I can see the changes are
> >   minor, to the level of fixing spelling errors in comments and variable
> >   names.
> > 
> > [1] https://github.com/nxengine/nxengine-evo
> 
> Yes, I made a fork with this engine where I made minor changes. I've already
> mentioned this mechanism in this package.

Frankly, you should only fork for important reasons. Minor changes are not.
Instead, work together with cavestory-nx and get your fixes merged.
 
> Thanks!
> 
> -- 
> ⢀⣴⠾⠻⢶⣦⠀ Carlos Donizete Froes (a.k.a coringao) <coringao@riseup.net>
> ⣾⠁⢠⠒⠀⣿⡁ Fingerprint: 2157 630B D441 A775 BEFF D35F FA63 ADA6 B638 B780
> ⢿⡄⠘⠷⠚⠋⠀ Debian Wiki: https://wiki.debian.org/coringao
> ⠈⠳⣄⠀⠀⠀