[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Bug#888246: marked as done (RFS: ddccontrol/0.4.3-1)

Your message dated Fri, 26 Jan 2018 09:30:43 -0500
with message-id <87mv10n14c.fsf@curie.anarc.at>
and subject line Re: Bug#888246: RFS: ddccontrol/0.4.3-1
has caused the Debian Bug report #888246,
regarding RFS: ddccontrol/0.4.3-1
to be marked as done.

This means that you claim that the problem has been dealt with.
If this is not the case it is now your responsibility to reopen the
Bug report if necessary, and/or fix the problem forthwith.

(NB: If you are a system administrator and have no idea what this
message is talking about, this may indicate a serious mail system
misconfiguration somewhere. Please contact owner@bugs.debian.org
immediately.)


-- 
888246: https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=888246
Debian Bug Tracking System
Contact owner@bugs.debian.org with problems
--- Begin Message ---
Package: sponsorship-requests
Severity: normal

Dear mentors,

I am looking for a sponsor for my package "ddccontrol"

 * Package name    : ddccontrol
   Version         : 0.4.3-1
   Upstream Author : https://github.com/orgs/ddccontrol/people
 * URL             : https://github.com/ddccontrol/ddccontrol
 * License         : GNU General Public License v2.0
   Section         : utils

It builds those binary packages:

    ddccontrol - program to control monitor parameters
    gddccontrol - program to control monitor parameters (graphical interface)
    libddccontrol-dev - development files for ddccontrol
    libddccontrol0 - shared library for ddccontrol

To access further information about this package, please visit the following URL:

    https://mentors.debian.net/package/ddccontrol

Alternatively, one can download the package with dget using this command:

    dget -x https://mentors.debian.net/debian/pool/main/d/ddccontrol/ddccontrol_0.4.3-1.dsc

Changes since the last upload:

  ddccontrol (0.4.3-1) unstable; urgency=low

  * New upstream release
  * debian/compat: increased compatibility level to 10
  * debian/control:
    * updated homepage to GitHub
    * updated VCS urls to GitHub
    * increased debhelper dependency version to 10
    * added build dependencies to build the release
  * debian/ddccontrol.docs: use README.md
  * debian/gddccontrol.dirs: install icons folder
  * debian/gddccontrol.install: install icons (moved from pixmaps)
  * debian/gddccontrol.menu: removed, because there is .desktop file
  * debian/libddccontrol0.postinst: removed, because ldconfig is called by
    trigger added by dh_makeshlibs/11
  * debian/libddccontrol0.postrm: removed, because ldconfig is called by
    trigger added by dh_makeshlibs/11
  * debian/rules: use autogen.sh, and enable-doc at configure

 -- Miroslav Kravec <kravec.miroslav@gmail.com>  Sat, 30 Dec 2017 11:56:57 +0100


Kind regards,
Miroslav Kravec

--- End Message ---
--- Begin Message --- 
On 2018-01-26 11:32:51, Miroslav Kravec wrote:
> On Thu, Jan 25, 2018 at 11:24 PM, Antoine Beaupre <anarcat@debian.org> wrote:
>> I have found some minor issues in the package that I think should be
>> fixed.
>>
>>  1. the lintian-override is not necessary. binary-without-manpage is
>>     just a warning, not an error, and we can live with it until the
>>     binary moves to the right place. in fact, it provides a good
>>     reminder that this still needs to be done, so do not override it.
>>
>>  2. in gbp.conf, "upstream-tree = 0.4.3" is out of place. it shouldn't
>>     be necessary because "upstream-tag = %(version)s" should work.
>
> I have fixed these two issues. The override was already there, in the
> original package. I have removed it as you suggested. It should be
> fixed, not suppressed.

Excellent.

>> Other comments, which are not blockers for an upload - but if you're
>> going to reroll the package anyways, might as well consider fixing this:
>>
>>  3. could you clarify why the override_dh_autoreconf target is
>>     necessary? isn't autoreconf exactly designed for the purpose of
>>     running autogen.sh?
>
> From man page 'dh_autoreconf is responsible for calling
> autoreconf...'. The autogen.sh contains also another command:
> intltoolize --force

Hmm.. i see. well i guess it makes sense then... why do we need to call
intltoolize --force there anyways? just a curiosity. :)

>>  4. it is quite strange to see a 10k line diff for a patch release
>>     (0.4.2 -> 0.4.3). I would encourage you to release a new *major*
>>     version (e.g. 0.5.0 or 1.0.0) next time you make such significant
>>     changes. not sure you can fix this now that the tag is public on
>>     github, so maybe just a note for next time...
>
> How did you perform diff? I ran following:
>
>   $ tar -xvf  ddccontrol_0.4.3.orig.tar.gz
>   $ tar -xvf ~/Downloads/ddccontrol_0.4.2.orig.tar.gz
>   $ diff ddccontrol-0.4.2 ddccontrol-0.4.3 | wc -l
>   305
>
> But, there are messages in diff, that some files are not present in
> latest version:
>
>   Only in ddccontrol-0.4.2: ABOUT-NLS
>   Only in ddccontrol-0.4.2: aclocal.m4
>   Only in ddccontrol-0.4.2: ChangeLog
>   Only in ddccontrol-0.4.2: config.guess
>   Only in ddccontrol-0.4.2: config.rpath
>   Only in ddccontrol-0.4.2: config.sub
>   Only in ddccontrol-0.4.2: configure
>   Only in ddccontrol-0.4.2: depcomp
>   Only in ddccontrol-0.4.2: INSTALL
>   Only in ddccontrol-0.4.2: install-sh
>   Only in ddccontrol-0.4.2: intltool-extract.in
>   Only in ddccontrol-0.4.2: intltool-merge.in
>   Only in ddccontrol-0.4.2: intltool-update.in
>   Only in ddccontrol-0.4.2: ltmain.sh
>   Only in ddccontrol-0.4.2: m4
>   Only in ddccontrol-0.4.2: Makefile.in
>   Only in ddccontrol-0.4.2: missing
>   Only in ddccontrol-0.4.2: mkinstalldirs
>   Only in ddccontrol-0.4.2: README

yeah, that's large part of the diff... "debdiff" will count those as
removed lines...

> These are mostly generated files, which shouldn't be in original
> sources. New files are:
>
>   Only in ddccontrol-0.4.3: autogen.sh
>   Only in ddccontrol-0.4.3: CheckList
>   Only in ddccontrol-0.4.3: commit.sh
>   Only in ddccontrol-0.4.3: .gitignore
>   Only in ddccontrol-0.4.3: README.md
>   Only in ddccontrol-0.4.3: .travis.yml

... and those as new lines. :)

> These files aren't code related. And, some of them probably need some cleanup.
>
> However, version 1.0.0 will be released once two major issues are done:
>
>  * public API (headers, D-Bus) will be finished, and properly documented,
>  * issue with root access/privileges requirement is fixed.

makes perfect sense, of course. i still encourage you to be liberal
about bumping the minor release number at this stage... it's a good
exercise...

>>  5. as lintian noticed, debian/copyright now has a formal syntax,
>>     specified by DEP5. no big deal, but you could do a refresh on that
>>     file. decopy is a tool that does this well.
>
> I just found that there's --pedantic option to lintian. Well, there
> are multiple notices, which should be fixed. I'll try to fix them all
> with next releases.

Awesome, thanks for... er... well being pedantic i guess. :) Again,
those are not major issues, but they help the project in the long run
(for example in doing automated licensing audits).

>> Once issues 1 and 2 are fixed, I'm happy to upload the package.
>
> Great. The new upload is now present on mentors:
> https://mentors.debian.net/package/ddccontrol

Awesome. I'll upload this shortly.

I have done one small change to the package before uploading, which I
failed to notice on the previous review. The diff should be
self-explanatory:

--- ../prev/ddccontrol-0.4.3/debian/changelog	2018-01-26 04:54:34.000000000 -0500
+++ debian/changelog	2018-01-26 09:25:25.660538042 -0500
@@ -7,6 +7,7 @@
     * updated VCS urls to GitHub
     * increased debhelper dependency version to 11
     * added build dependencies to build the release
+    * adopt the package (Closes: #483479)
   * debian/ddccontrol.docs: use README.md
   * debian/ddccontrol.lintian-overrides, debian/lintian-overrides: removed,
     because it should be fixed, not suppressed warning

I figured it was not worth another round-trip, but you may want to
commit this in the git repo as well to make sure things are in sync.

In general, before doing an upload, it's a good idea to look at the BTS
page for the package to see if there are any pending patches or issues
that would be fixed by the upload:

https://bugs.debian.org/cgi-bin/pkgreport.cgi?repeatmerged=no&src=ddccontrol

You can close some by hand after the upload, but it's better to do that
in the changelog, as in the above. The tracker page is also a great
resource:

https://tracker.debian.org/pkg/ddccontrol
https://tracker.debian.org/pkg/ddccontrol-db

... and so is your own QA page:

https://qa.debian.org/developer.php?email=kravec.miroslav%40gmail.com

Do CC me if you file a sponsorship request again, if you need a sponsor
of course. Otherwise I will not notice it, as I do not actively monitor
all requests.

Cheers!

a.

-- 
Il faut tout un village pour élever un enfant.
                        - Proverbe africain

--- End Message ---
Reply to: