[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Bug#887369: RFS: libreoffice-style-papirus/20170228-1 [ITP]



Hi,

On Tue, Jan 16, 2018 at 11:01:32PM +0100, Adam Borowski wrote:
> On Tue, Jan 16, 2018 at 08:20:10PM +0100, I wrote:
> > An icon theme might be more work than a cursor or window theme as whatever
> > needs the new icon would borrow from another theme and thus look out of
> > place.
> > 
> > > You can have another opinion. If not I will close the RFS and ITP in
> > > the next few days.
> > 
> > This is your time, no one has the right to tell you what to work on (at
> > least not in Debian).  You maintain a diverse set of packages, so a theme
> > that's not a part of your main area has a pretty low priority.
> 
> I just learned that Deepin's default theme is based on Papirus, which makes
> this package a matter of adjusting LibreOffice to match, rather than just a
> random unrelated theme.
> 
> I don't know if there's a reasonable way to make LibreOffice default to this
> theme when started from Deepin -- if not, it'd require a manual action from
> the user, which hardly anyone is going to do.

LO has it:
https://cgit.freedesktop.org/libreoffice/core/tree/vcl/source/app/IconThemeSelector.cxx?h=libreoffice-6-0-0#n50

This would need to be amended to detect Deepin (there's also desktop
detection..)

But then still there's the point I raised: the libreoffice part was last
touched 1 year ago. In the meanwhile there have been icon changes here
and there in LO and 6.0.0 is around the corner. Who is going to support
this and eventual inconsistencies when icons are missing? (LOs -style
packages have fallback Depends: to the "last-resort-fallback" tango,
but...)

Regards,

Rene


Reply to: