Bug#887126: RFS: ddupdate/0.2.0-1 #886546
Alec Leamas kirjoitti 14.01.2018 klo 11:07:
> I am looking for a sponsor for my package "ddupdate"
Here's a review, but please note that I cannot sponsor you.
I don't have network admin knowledge, so I didn't test the functionality of ddupdate.
Please use up-to-date lintian. It'll give you an error tag and several
informational and pedantic tags, some of which are easily dealt with.
This review is based on the package you have uploaded to mentors, but I also
had a look at your git repo, where you wrote in a commit message:
> debian: Fix Standards-Version: to current sid 4.0.0
Your sources for that information are outdated, you should check [1] instead.
At the mentors site, you write:
> I cannot understand what's wrong with the copyright file. I guess it's a silly oversight.
>
> uscan works just fine for me, the watch file error seems weird.
If you're referring to "P: ddupdate source: no-dep5-copyright", it's because your
debian/copyright doesn't follow the specification[2]: it doesn't have a header paragraph
and the license text for MIT isn't specified.
Uscan works for me as well, mentors.debian.net has a broken check indeed.
debian/control: Please add Vcs-Git. To specify the branch, see Policy[1] §5.6.26.
Typo in Description: ubiquotious->ubiquitous.
debian/ddupdate-docs.docs: There is no "ddupdate-docs" binary package so this file
doesn't do anything[3], please remove.
debian/README.debian: Typo: updatet->updated. I think Debian should be capitalized
as a proper noun in user documentation.
debian/rules:
Debhelper has picked Makefile instead of setup.py, so you should add
"--buildsystem=pybuild" after the --with arguments. Then you can remove override_dh_build,
override_dh_auto_install and override_dh_python3 rules, and delete the file debian/install.
However, this causes that every file that setup.py installs goes into the package.
To control what gets installed, you can add something like this to debian/rules:
override_dh_install:
dh_install
rm debian/ddupdate/usr/share/doc/ddupdate/CONTRIBUTE.md \
debian/ddupdate/usr/share/doc/ddupdate/LICENSE.txt
The installed package is missing some Depends: "ModuleNotFoundError: No module named 'straight'".
The Depends will be automatically added if you implement the debian/rules changes
that I suggested above.
Regards,
Juhani
[1] https://www.debian.org/doc/debian-policy/
[2] https://www.debian.org/doc/packaging-manuals/copyright-format/1.0/
[3] See manpage for dh_installdocs(1)
Reply to: