Dear Guillaume, On Sun, 11 Nov 2018 12:26:21 -0500 Guillaume Brochu <guillaume.brochu@gmail.com> wrote: > Package: sponsorship-requests > Severity: normal > I am looking for a sponsor for the package "geneweb", that is in Debian > since July 2000. > Following closure of #908850 and a e-mail communication with Boyuan Yang, > here is a new upload for the geneweb package. > > * Package name : geneweb > Version : 6.08+git20181019+dfsg-1 > Upstream Author : Daniel de Rauglaudre et al. > * URL : https://github.com/geneweb/geneweb > * License : GPL-2 > Section : misc I did a quick review of the package. The debian/copyright file needs to be fixed: – the copyright years for the main INRIA copyright notice are incomplete. My understanding is that it should now be at least 1998- 2012 – there is a missing attribution for the file contrib/gwdiff/gwdiff.ml, which is Copyright © 2001 Ludovic LEDIEU (the easiest solution is probably to create a new stanza for that one) – around the end of the "GPL-2" paragraph, at the end of the paragraph giving the FSF address, there is a spurious "License: GPL-2+" that should be removed Otherwise the package looks good. Here are a few things that you might want to improve, but that I don't consider as a blocker for an upload: – all the Pre-Depends on "dpkg (>= 1.15.6~)" could be removed, because even wheezy has a version of dpkg that satisfies this constraint – debhelper compat level could be bumped to 11 – you could migrate to the new way of specifying debhelper compat level (removing debian/compat, and specifying "debhelper-compat (= NN)" in Build-Depends, see debhelper(1)) – most entries (if not all) in the debian/*.dirs files are useless; these files should only be used to create empty directories; otherwise, directories are automatically created by debhelper once you install a file in them – you could bump Standards-Version to 4.3.0 (that has just been released) Best, -- ⢀⣴⠾⠻⢶⣦⠀ Sébastien Villemot ⣾⠁⢠⠒⠀⣿⡁ Debian Developer ⢿⡄⠘⠷⠚⠋⠀ http://seb astien.villemot.name ⠈⠳⣄⠀⠀⠀⠀ http://www.debian.org
Attachment:
signature.asc
Description: This is a digitally signed message part