[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Bug#914174: RFS: easy-rsa [ITA]

On 11/21/18 3:14 PM, Adam Borowski wrote:
> On Wed, Nov 21, 2018 at 02:27:17PM +0100, Michele Orru wrote:
>> On 11/21/18 6:45 AM, Adam Borowski wrote:
>>> On Tue, Nov 20, 2018 at 08:45:09AM +0100, Michele Orrù wrote:
>>>> * Package name    : easy-rsa
>>>>     Version         : 3.0.5-1
>>>>      https://salsa.debian.org/maker-guest/easy-rsa/
>> thanks a lot for your prompt response!
>> I really apologise for the silly mistake on dh_installdocs: it should be
>> fixed now, together with the other issues you reported.
>> I pushed the modifications on salsa, and uploaded the package on
>> mentors.debian.net
> Awesome.
> There's one more issue that's better to fix before uploading:
>   Maintainer: Debian QA Group <packages@qa.debian.org>
> -- you'd want to update this.

… right, thanks again. It should be fixed now (both on mentors and on salsa).

>> I also took the liberty of removing: ${shlibs:Depends} from the list of
>> dependencies. They were empty, plus easy-rsa is just a shell script that
>> relies solely on openssl, which is explicit in the package. Hope that's
>> fine.
> It's generally better to keep this even if unused as an empty var that's
> referenced is ok but a non-empty var that's missing would cause problems.
> This might happen if you one day need to include a bit of compiled code
> in the package.  But then, for now there's no difference either way.

I see your point, I'll keep that in mind. However, unless you really think it would be best to keep it, I'd leave as it is to get rid of that lintian warning.

I also went through:
to update the Standards version, which apparently required no additional changes to the package, or the metadata. Hope that's fine.


Reply to: