Bug#911867: RFS: frr/6.0.1-1 [ITP]
Hi Herbert,
Thanks for your input! FWIW I started out with a whole lot of lintian
errors and warnings and am happy to be down to informational messages ;)
On Sat, Oct 27, 2018 at 08:19:23AM -0300, Herbert Fortes wrote:
> On 10/25/18 3:17 PM, David Lamparter wrote:
> I no-symbols-control-file
> usr/lib/x86_64-linux-gnu/libfrrospfapiclient.so.0.0.0
> usr/lib/x86_64-linux-gnu/libfrr.so.0.0.0
>
> https://wiki.debian.org/UsingSymbolsFiles
Symbols files are only applicable to libraries providing a stable ABI.
This is explicitly not the case for FRRouting (hence also the 0.0.0
.so version.)
> I spelling-error-in-binary # a lot
> I spelling-error-in-manpage # a lot
I fixed these upstream in https://github.com/FRRouting/frr/pull/3247
Some of the spellcheck warnings are also bogus since the spellchecker
misdetects function names (e.g. writen()) as english words ("written".)
> O package-name-doesnt-match-sonames
> libfrr0 libfrrospfapiclient0 (override comment: libfrr* are for internal use only and do not provide a stable API or ABI. soname / library versioning is irrelevant and they must always be shipped exact-matching to the daemons compiled against it)
>
> It is a package name. That's all.
> The lib can not be trusted?
The lib is an integral part of a FRRouting version; the daemons and the
.so must match up. As noted above on the symbols file, the .so version
is not currently used since the ABI is not stable. The "0" does not
convey any useful information.
> P package-uses-old-debhelper-compat-version
> 9
>
> There is a problem with version 11?
Probably nothing. The package used version 7 before I started working
to upgrade it and I bumped it up to and tested version 9 since that's
not deprecated.
Note that this is a "pedantic" level warning so I'm going to fix other
stuff before getting to this :)
> O alternatively-build-depends-on-python-sphinx-and-python3-sphinx
> (override comment: these are for build-compatibility on older distros (e.g. Ubuntu 14.04))
>
> It is a new package. It is preferable to not upload Python 2
The Debian packaging for FRRouting is currently maintained in upstream
git and supported on Debian jessie, stretch, buster, sid as well as
Ubuntu 14.04, 16.04, 17.10, 18.04 (+ 18.10.) This build dependency was
a concession to make building on old platforms easier - probably for
Ubuntu 12.04 (which has been dropped upstream in 6.0.) The entire
package works fine with only Python3 and no remains of Python2
installed.
Since both Ubuntu 14.04 and Debian jessie do have python3-sphinx, I'll
check whether we can ditch the Python2 stuff in general (there's also a
python/python3-dev build-dep) without breaking 14.04/jessie.
Cheers,
-David
P.S.: I'm still polishing the packaging, working to reduce the number of
lintian informational messages, but I also noticed some problems with
the init/service architecture that are higher priority to fix.
Reply to: