[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Bug#910608: RFS: libtheft/0.4.5-1 ITP #910296



Hi!

I just had a quick look at the libtheft packaging on mentors, and
noticed a few things that at the moment, prevent me from sponsoring the
package. These are:

- I was unable to find the public part of your GPG key, thus, was unable
  to verify the signature on the source package. Where can one find it?
  (Uploading it to a public key server might be best).
- The package build-depends on `debhelper-compat (= 11)`, which works,
  but it's a virtual package. I'd suggest build-depending on `debhelper
  (>= 11)`, and adding a `debian/compat` file with "11" as its content.
  This will get rid of one of the warnings on mentors, too.
- debian/copyright does not document the license of `src/theft_hash.c`
  (public domain, but that needs to be documented too).
- debian/copyright does not document the license and author of
  `debian/*`. In most cases - and theft is no exception - the Debian
  packager is not the upstream author. If unspecified, the `*` wildcard
  applies to `debian/*` too, which would be incorrect.
- The control file does not set a Homepage - a minor thing, but while
  fixing the other issues, might as well fix this one, and point the
  Homepage field in debian/control to theft's GitHub.

Other than these, the package looks ok. Can you fix the above?

Drop me an email when done, and I'll have another look.

-- 
|8]


Reply to: