[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Bug#909949: RFS: android-platform-system-extras/8.1.0+r23-1 (experimental)



Dear Kai-Chung,

On Wed, Oct 3, 2018 at 2:05 AM 殷啟聰 | Kai-Chung Yan <seamlikok@gmail.com> wrote:
>
> Thanks for the sponsor again, Roger!
>
> I did push the changes already, check <https://salsa.debian.org/android-tools-team/android-platform-system-extras/compare/debian%2F7.0.0+r33-1...master>.
>
> Or do you mean you want a dedicated merge request so you can leave comments their so that in a more sophisticated way? That's probably not viable...

I did a quick review.
Since you removed a few stuff from upstream, such as unused test data,
jar, etc, the upstream source need to be called "repack", or debian
source [1].
And all removed stuff need to be listed in debian/copyright. (I see
you already handled this.)
In this way, the repack can be done automatically by uscan. (nice to
do, but not must)

[1] https://wiki.debian.org/BenFinney/software/repack

The problem is you didn't mention +ds or +repack in version in d/changelog.
I guess the version need to be changed to 8.1.0+r23+ds-1 or 8.1.0+r23+repack-1.

Cheers,
-- 
Roger Shimizu, GMT +9 Tokyo
PGP/GPG: 4096R/6C6ACD6417B3ACB1


Reply to: