Bug#908061: RFS: rapid-photo-downloader/0.9.11-1
On 2018-09-16 18:47:10, Antoine Beaupré wrote:
> On 2018-09-10 12:13:00, Antoine Beaupré wrote:
>> On 2018-09-08 14:37:00, Jörg Frings-Fürst wrote:
>>> -----BEGIN PGP SIGNED MESSAGE-----
>>> Hash: SHA512
>>>
>>> Hello Antoine,
>>>
>>> many thanks for your review.
>>
>> Hi!
>>
>> A pleasure working with you!
>>
>>> Am Mittwoch, den 05.09.2018, 13:01 -0400 schrieb Antoine Beaupré:
>>>> Control: owner -1 anarcat@debian.org
>>>>
>>>> On 2018-09-05 18:39:07, Jörg Frings-Fürst wrote:
>>>> > -----BEGIN PGP SIGNED MESSAGE-----
>>>> > Hash: SHA512
>>>> >
>>>> > Package: sponsorship-requests
>>>> > Severity: normal
>>>> >
>>>> > Dear mentors,
>>>> >
>>>> > I am looking for a sponsor for my package "rapid-photo-
>>>> > downloader"
>>>>
>>>> Hi!
>>>>
>>>> As the uploader for the package, I'll be happy to sponsor this.
>>>>
>>>> I've reviewed your changes and they seem mostly good. However, they
>>>> seem
>>>> to omit some changes I've uploaded to the git repository 4 weeks ago:
>>>>
>>>> https://salsa.debian.org/debian/rapid-photo-downloader
>>>>
>>>> ... namely:
>>>>
>>>>
>>> https://salsa.debian.org/debian/rapid-photo-downloader/commit/ff0358a5e0783fb2464391cd06d02021a881ccae
>>>>
>>> https://salsa.debian.org/debian/rapid-photo-downloader/commit/c0027837223b83325d653a59146e16d2206fcccf
>>>>
>>>> Those are necessary (I think?) to completely fix #900709.
>>>>
>>>> With those changes, I'll be happy to do the upload.
>>>>
>>>
>>> Sorry. I have first sync only the release 0.9.9-2. Your commits are now
>>> included. The package is uploaded to mentors[1].
>>
>> Understood. I had a conflict when merging the code from salsa with yours
>> because you keep the removed patch commented out (I just removed the
>> line) in debian/patches/series. I've also removed the unused patches
>> from debian/patches so we have only this one patch remaining.
>>
>> Another thing that's missing from the above .dsc file is the
>> "python3-colour" Depends. Any idea why that's also missing?
>>
>> I've pushed my resulting merge to salsa for now.
>>
>>>> I would also encourage you to register on salsa.debian.org and upload
>>>> your changes there, as it will make future collaboration easier: it
>>>> would have avoided such confusion, for example.
>>>>
>>>
>>> I do not use salsa because of the existing user restrictions.
>>
>> What do you mean by that?
>
> Hi!
>
> Any update here?
Ping! Could you provide an updated package with the new Depends?
Otherwise I'm happy to make the corrections myself.
Thanks!
A.
--
Vivre tous simplement pour que tous puissent simplement vivre.
- Gandhi
Reply to: