Bug#903904: RFS: wannier90/2.1.0 -- maximally localized Wannier functions

[Adam Borowski <kilobyte@angband.pl>]

On Mon, Jul 16, 2018 at 03:44:21PM +0300, Andrius Merkys wrote:
> * Package name    : wannier90
>   Version         : 2.1.0
>   Upstream Author : Mostofi et al.
> * URL             : http://www.wannier.org
> * License         : GPL-2+
>   Programming Lang: Fortran
>   Description     : maximally localized Wannier functions
> 
> It builds these binary packages:
>   wannier90        - Maximally Localized Wannier Functions - executables
>   libwannier90-dev - Maximally Localized Wannier Functions - development files

While I cannot adequately review this package, and thus won't sponsor it,
here's a couple of problems:

1. The copyright file claims GPL-2+ with no authors outside "2017 Wannier
Developers' Group", yet I see at least test-suite/testcode being:
"Copyright (c) 2012 by James Spencer", license: BSD.

2. The package fails to build:

! LaTeX Error: File `ulem.sty' not found.

Type X to quit or <RETURN> to proceed,
or enter new name. (Default extension: sty)

Enter file name: 
! Emergency stop.
<read *> 
         
l.19 \newcommand
                \tent[1]{\textcolor{red}{#1}}     % for tentative changes^^M
!  ==> Fatal error occurred, no output PDF file produced!



Meow!
-- 
⢀⣴⠾⠻⢶⣦⠀ What Would Jesus Do, MUD/MMORPG edition:
⣾⠁⢰⠒⠀⣿⡁ • multiplay with an admin char to benefit your mortal [Mt3:16-17]
⢿⡄⠘⠷⠚⠋⠀ • abuse item cloning bugs [Mt14:17-20, Mt15:34-37]
⠈⠳⣄⠀⠀⠀⠀ • use glitches to walk on water [Mt14:25-26]