Bug#904069: RFS: xsunpinyin/2.0.3-5 [RC]
Hello GengYu Rao,
comments inlined below.
On Thu, Jul 19, 2018 at 05:57:42AM +0000, GengYu Rao wrote:
> Package: sponsorship-requests
> Severity: important
> Dear mentors,
>
> I am looking for a sponsor for my package "xsunpinyin"
>
> * Package name : xsunpinyin
> Version : 2.0.3-5
[...]
> dget -x https://mentors.debian.net/debian/pool/main/x/xsunpinyin/xsunpinyin_2.0.3-5.dsc<https://mentors.debian.net/debian/pool/main/x/xsunpinyin/xsunpinyin_2.0.3-4.dsc>
(^^^ broken!)
>
>
> Changes since the last upload:
>
> migrate to salsa, and fixed URLs.
>
>
> the repo is here https://salsa.debian.org/input-method-team/xsunpinyin
Every commit is quite a mess, which is likely a contributing factor why
you missed that you bumped compat from 7 -> 11, which isn't mentioned
anywhere, in this commit:
https://salsa.debian.org/input-method-team/xsunpinyin/commit/9630740c826b66ca615436283b590c75da62b7ab
Such a compat change is something which needs to be carefully reviewed
and not even mentioning it in the debian/changelog or in your
sponsorship request rings a warning bell for me (and thus I stopped
looking for other possible issues).
Please consider in the future to spend more time writing useful commit
messages, one change per commit, marking "typo" commits with 'Gbp-Dch:
ignore' (see man gbp dch), (re)view the changes you're about to commit
before doing so (using git commit -v) and finally generate
debian/changelog using 'gbp dch --auto' to avoid missing to mention
certain changes.
It's also good to stay away from whitespace changes all over the place
(as done by "helpful editors") as that makes diff/review your work
unneccesarily hard.
I'm not uploading (atleast in the current state), but hope that my
comments was somewhat useful to you.
Regards,
Andreas Henriksson
Reply to: