Re: Bug#883702: RFS: lina/5.3.0-1 ( #859130 ITP: lina -- iso-compliant Forth interpreter and compiler )
On Mon, Jul 02, 2018 at 05:32:40PM +0200, Albert van der Horst wrote:
> (An earlier non-personal call for reviews yielded no reactions.)
> I eagerly await your review of
> https://mentors.debian.net/package/lina
> especially whether it complies with the "preferred form of modification"
> guidelines.
The current version of the package fails to build:
makeinfo lina.texinfo --no-split -o lina.info
make[1]: makeinfo: Command not found
make[1]: *** [Makefile:52: lina.info] Error 127
which is trivially fixable by adding texinfo to Build-Depends.
Besides that, in a cursory review, I don't see any other issues.
I can't claim I understand your build system, though. And unlike not
understanding merely the packaged program's functionality, I don't think I
can sign this myself. Thus, it'd be nice if someone else took a look as
well. I don't quite see what's the new relation between ciforth and lina,
too.
Meow!
--
// If you believe in so-called "intellectual property", please immediately
// cease using counterfeit alphabets. Instead, contact the nearest temple
// of Amon, whose priests will provide you with scribal services for all
// your writing needs, for Reasonable And Non-Discriminatory prices.
Reply to: