[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Bug#898974: RFS: ibus-keymagic/1.5.2 [ITP. NMU]



Control: retitle -1 RFS: ibus-keymagic/1.5.2 [ITP]
Control: tag -1 + moreinfo
X-Debbugs-CC: kokoye2007@gmail.com

On Fri, 18 May 2018 11:03:36 +0630 "Ko Ko Ye`" <kokoye2007@gmail.com> wrote:
> Package: sponsorship-requests
> Severity: wishlist
> 
> Dear mentors,
> 
>   I am looking for a sponsor for my package "ibus-keymagic"
> 
> Package name    : ibus-keymagic
> Version         : 1.5.2
> Upstream Author : kokoye2007 <kokoye2007@gmail.com>
> URL             :  keymagic.net
> License         : gpl2
> Section         : utils
> 
>   It builds those binary packages:
> 
>     ibus-keymagic - keymagic engine for IBus
> 
>   To access further information about this package, please visit the
> following URL:
> 
>   https://mentors.debian.net/package/ibus-keymagic
> 
> 
>   Alternatively, one can download the package with dget using this command:
> 
>     dget -x
> https://mentors.debian.net/debian/pool/main/i/ibus-keymagic/ibus-keymagic_1.5.2.dsc
> 
>   More information about hello can be obtained from keymagic.net
> 
> 
>   Changes since the last upload:
> 
> https://code.launchpad.net/~kokoye2007/+junk/ibus-keymagic
> https://code.launchpad.net/~kokoye2007/+recipe/ibus-keymagic

Hello,

I am not going to sponsor your package nor making a thorough review, however 
I'd like to point out some problems here:

* Introducing native package format for software that is not originated from 
Debian will almost 100% be questioned and even rejected. Please use the non-
native package format.

* debian/changelog: You wrote two changelog entries of the same version. That 
is unacceptable and must be fixed.

* Debian Policy chapter 3.4 requires that "The description should describe the 
package (the program) to a user (system administrator) who has never met it 
before so that they have enough information to decide whether they want to 
install it. This description should not just be copied verbatim from the 
program’s documentation.". However, your package description are not even 
complete English sentences. Please rewrite them and correctly describe the 
function of the package.

* debian/rules: Not using dh(1) sequencer for new packages with debhelper 
compat >= 9 is highly discouraged. Please read debhelper's documentations and 
see if it could be improved.

* debian/changelog.in and Makefile.am: Manipulating debian/changelog from 
instructions outside of debian/ dir is highly discouraged and will certainly 
leads to package rejection. Please make solid separation between "upstream" 
source code and Debian's packaging instructions. If you have to manipulate and 
generate debian/changelog file when building, please do it in debian/rules.

* debian/copyright: Your debian/copyright file is not following machine-
readable copyright format as described in
https://www.debian.org/doc/packaging-manuals/copyright-format/1.0/ . Please 
consider rewriting it. It is not a critical problem, though.

Please consider fixing issues above or giving proper explanations before 
requesting further reviews. Thanks!

--
Regards,
Boyuan Yang

Attachment: signature.asc
Description: This is a digitally signed message part.


Reply to: