Control: forcemerge -1 898773
Control: owner -1 !
Control: tag -1 moreinfo
Control: retitle -1 RFS: python-fibra [ITP]
On Thu, May 17, 2018 at 01:47:30PM -0500, Mario Frasca wrote:
> I'm looking for a sponsor for my package 'fibra'.
Hi Mario,
I'll be looking at this RFS of yours, and provide a review both of your
work on the workflow you seem to have employed.
> It is now marked as "no" in the column "needs a sponsor", in my page
> "https://mentors.debian.net/packages/uploader/mario%40anche.no";, even if
> I opened bug report 898773.
That's a flag you'd need to change yourself on mentors.d.n, anyway, we
don't really care about that as the ones needing a sponsor need to open
a RFS bug anyway.
> dget -x
> https://mentors.debian.net/debian/pool/main/f/fibra/fibra_0.0.18-1.dsc
>
> Changes since the last upload:
>
> I've removed all the warnings in the debuild/lintian process as far as I
> could see from the machine where running debuild.
You have opened two RFS bugs for the same package despite it not ever
being uploaded to the debian archive. Please keep only one. I've
merged them and I'm writing on the newest one just because the other has
unrelated history on it.
Now, I've downloaded the version 0.0.20-1 that you uploaded in the
meantime, so I'll look at that.
* d/changelog:
+ please only keep one paragarph, you should not create new paragraph
until it's uploaded to the archive. Only the line with "Inital
packaging" should stay.
+ also please use urgency=low for a new upload
* d/compat:
+ any reason not to use the newest compat level available? See
debhelper(7) for the difference
* d/control:
+ I'm sure lintian is emitting tons of warning about this file. Have
you run lintian on it?
* d/fibra.1:
+ I understand you adopted the upstream maintenance of this package,
so why not move the manpage upstream and have the upstream build
system install it, etc?
+ at any rate, you are not providing any binary, so I can't figure
what that manpage should be documenting, not to mention it's not
installed anyway
* d/fibra-docs.doc:
+ you are not building any such package, so what is this file about?
+ also referring a non-existing file?
* d/fibra.doc-base:
+ likewise. And I'm sure lintian talks about this file as well?
* d/README.Debian:
+ another contentless file??
* d/rules:
+ please get rid of all those uselless comments that only mkes
reading of an otherwise simple rules file needlessly harder
* d/copyright:
+ you wrote 2009 as the upstream year, but README says 2007
+ I understand you did a bunch of upstream work too, but you haven't
claim any copyright for it?
* do you actually need to introduce the python2 package? We are going
to need remove them next year or so while removing python2, so
introducing a new py2 module is kind of weird
When you run lintian please always run the most recent version from
testing/sid if you are running buster, or from stretch-backports if you
are running stretch (actually, you should be building your package in a
sid chroot, it's a good habit to instruct your software to run lintian
automatically inside the chroot after the build), and use the flags
-Ii --pedantic
to have also the pedantic tags.
You also seem to not be maintaining this package in any VCS, which is
considered a weird habit in this age. Have you heard about gbp?
--
regards,
Mattia Rizzolo
GPG Key: 66AE 2B4A FCCF 3F52 DA18 4D18 4B04 3FCD B944 4540 .''`.
more about me: https://mapreri.org : :' :
Launchpad user: https://launchpad.net/~mapreri `. `'`
Debian QA page: https://qa.debian.org/developer.php?login=mattia `-
Attachment:
signature.asc
Description: PGP signature