Bug#896714: RFS: cavestory-nx/1.0.0-1 [ITP] -- NXEngine is a Cave Story game engine clone
Control: tags -1 moreinfo
Hi Carlos,
Some general remarks: Please do not open new RFS bugs for new versions
of your package if the previous one has not been sponsored.
Reopen the bug, retitle it appropiatly and send the RFS to the old bug
please. (that this is something I've told you already earlier.)
Now let's review cavestory-nx:
Debian-Packaging:
- There is a wrapper script in /usr/share/games calling
/usr/share/games/cavestory-nx which is a symlink to ../../../lib/games/cavestory-nx/cavestory-nx
This feels quite wrong...
- Can't the executable not installed to /usr/share/games/ directly?
- as you're upstream, please include the manpage also there, so that
other distributions will benefit from it more easily.
- you can also use the file d/clean for cleaning, sparing you of the
override of dh_auto_clean.
- There seems to bean embedded code copy of nlohmann-json.
- That means also that your d/copyright is incomplete.
Please make sure to go over _every_ file to ensure that d/copyright
is accurate. There are tools like licensecheck or license-reconsile
to aid you with this.
Others / ITP related / Project related.
- there is a Readme.txt on the game assests stating that this is free
software but there is no license text attached. As "free" is ambiguous,
Can you please elaborate the source where you've got the data from?
I've only found some data file at the original authors website, but it
is lacking this Readme.txt. (I can't find the rationale why you say it
is Public Domain)
- as you've seem have to forked from nxegine-evo [1], can you go a bit
into the reasons of your fork. As far as I can see the changes are
minor, to the level of fixing spelling errors in comments and variable
names.
[1] https://github.com/nxengine/nxengine-evo
(I'm BCC'ing the ITP as the "Others" sections would actually belong
there, but I do not want to join those threads (therefore BCC)
--
tobi
Reply to: