On Thursday, April 26 2018, Joel Cross wrote: > Hi Sergio, Hey, Joel, > Thanks for all the comments. I've addressed most of them and re-uploaded the package. As for this one: Hm, from what I've seen the package is pretty much the same as it was when you submitted it. I'm using the following repository: https://salsa.debian.org/python-team/modules/python-cerberus And I don't see the fixes I asked you to do. Maybe I'm looking at the wrong place? >> 2) On d/rules, there's no need to override dh_compress. It > automatically excludes HTML files when compressing things. > > I read in the docs that HTML files are supposed to be excluded, but > for some reason the one HTML file changelog.html was being gzipped. I > couldn't figure out why, but adding the exclude line fixed the > problem. Ah, thanks for explaining. I didn't know that. I guess it has something to do with the name "changelog"; it's probably installed by dh_installchangelogs... Can you please add a comment on top of the override_dh_compress rule explaining this, then? Thanks, -- Sergio GPG key ID: 237A 54B1 0287 28BF 00EF 31F4 D0EB 7628 65FC 5E36 Please send encrypted e-mail if possible http://sergiodj.net/
Attachment:
signature.asc
Description: PGP signature