Control: tags -1 + moreinfo On Tuesday, April 17 2018, Joel Cross wrote: > Dear mentors, > > I am looking for a sponsor for my package "python-dataclasses" > > * Package name : python-dataclasses > Version : 0.5-1 > Upstream Author : Eric V. Smith <eric@python.org> > * URL : https://github.com/ericvsmith/dataclasses > * License : MIT > Section : python > > It builds those binary packages: > > python3-dataclasses - Python dataclasses backport from 3.7 > > To access further information about this package, please visit the following > URL: > > https://mentors.debian.net/package/python-dataclasses > > > Alternatively, one can download the package with dget using this command: > > dget -x https://mentors.debian.net/debian/pool/main/p/python- > dataclasses/python-dataclasses_0.5-1.dsc > > More information about Python dataclasses can be obtained from > https://www.python.org/dev/peps/pep-0557. Hi, Joel, Thanks for the interest! I briefly looked at the package and noticed a few things worth fixing/addressing. Keep in mind this is a non-exhaustive list; there may be other issues, but I think it's a good idea to put the package in a good shape first. 1) This package (and other Python packages you've submitted for sponsorship) can be packaged together with the Debian Python team. Unless you have a reason not to do that, this is the recommended way to do Python packaging. A good starting point to know more about the team is <https://wiki.debian.org/Python> and <https://wiki.debian.org/Teams/PythonModulesTeam>. 2) Your package is not using the latest debhelper (v11), the latest Standards-Version (4.1.4.1), doesn't provide Vcs-* links (in other words, where is the package repository?), d/compat is "10" (should be "11"). If you're going to package under the Debian Python team, please look at the specific instructions on how to fill the Maintainer/Uploaders fields. 3) As mentioned above, you did not provide any git repository where we can find your package. It is extremely important that you do that, and I strongly recommend following the "git-buildpackage" workflow. You can create a guest user account on https://salsa.debian.org and create a repository there, if you need. Eventually (when the package is accepted) this repository will be moved to either the Debian namespace or the Debian Python Team namespace, depending on what you choose to do. 4) d/copyright mentions "MIT", but that's a generic name that covers many types of licenses. Judging by the license text you used there, the license name should be "Expat". *However...* 5) I don't see any copyright notice on the upstream project whatsoever. Actually, the only notice I see (in the file "pep-0557.rst") mentions: Copyright ========= This document has been placed in the public domain. But I understand that this notice only applies to the file itself, not to the whole project. Which begs the question: where did you see that the project is licensed under Expat? /me looks once more... Ah! Found it. It's listed in the "setup.py" file. Hmm... I wonder if that's a problem, because no other file contains any kind of copyright notice, and there's no LICENSE file. I'd definitely file a bug against upstream asking them to clarify this, but I honestly don't know if ftp-master will accept the package as is. Maybe there's some precedence, but I'm short on time right now and can't really dive into the archives to find something. Perhaps someone more knowledgeable can chime in? All right, I'll stop the review for now. I'll keep an eye on any updates here, and will be happy to upload the package once we sort everything out. Cheers, -- Sergio GPG key ID: 237A 54B1 0287 28BF 00EF 31F4 D0EB 7628 65FC 5E36 Please send encrypted e-mail if possible http://sergiodj.net/
Attachment:
signature.asc
Description: PGP signature