Hi Lumin, upload to mentors done, please check: https://mentors.debian.net/package/taptempo Regards, François Le mardi 03 avril 2018 à 06:17 +0000, Lumin a écrit : > Hi François, > > On 31 March 2018 at 21:59, François Mazen <francois@mzf.fr> wrote: > > > > This program is useful to quickly find the tempo of a song. > > The idea is to type "taptempo" in a terminal, then hit enter key at > > each beat while hearing a song, and display the tempo. > > > > The targeted people are mainly musicians who need to transcribe > > music > > or play the song at the exact original tempo. The typical situation > > to > > use this software is when you are in a hurry and you don't have > > time to > > launch a big workstation like Ardour or Lmms in order to find the > > tempo. > > Got it. Thank you for this explanation. > > > > > > 8. When you have built the latest version of the modified > > > package, > > > you could run lintian against it: > > > > > > lintian -EviI --pedantic xxxx.changes > > > > > > There generally shouldn't be any Error or Warning. > > > > I've fixed all the error and the lintian output should be clean. > > You have done quite a good job making the package in a good shape, > and making the upstream very standard. > > By the way I'm surprised that you have fixed all lintian outputs, > including the pedantic stuff. The pedantic items are only optional, > not what must be fixed. Errors and Warnings should be dealt with, > and some lintian Info can even pass if the maintainer has a good > reason. > > In return everything's shining and in good shape :-) > > > Let me know if it still require more work. > > Nitpicking: > > 1. Please collapse the two lines in changelog into one. They refer to > the same thing. > > - * Initial debian package. > - * Closes: #893306 > + * Initial debian package. (Closes: #893306) > > 2. there is still an autpkgtest problem: > > autopkgtest [07:01:02]: test version: [----------------------- > spawn taptempo --version > couldn't execute "taptempo": no such file or directory > while executing > "spawn taptempo --version" > (file > "/tmp/autopkgtest.C3pEq9/build.uWo/src/debian/tests/version" line 6) > autopkgtest [07:01:03]: test version: -----------------------] > autopkgtest [07:01:03]: test version: - - - - - - - - - - results - > - > - - - - - - - - > version FAIL non-zero exit status 1 > autopkgtest [07:01:03]: test version: - - - - - - - - - - stderr - - > - - - - - - - - > couldn't execute "taptempo": no such file or directory > while executing > "spawn taptempo --version" > (file > "/tmp/autopkgtest.C3pEq9/build.uWo/src/debian/tests/version" line 6) > > this can be fixed by the patch. It looks somewhat wired but we need > it. > > --- a/debian/tests/control > +++ b/debian/tests/control > @@ -1,2 +1,2 @@ > Tests: version, help, tempo > -Depends: expect > +Depends: expect, taptempo > > The autopkgtest result after patched: > > http://debomatic-amd64.debian.net/distribution#unstable/taptempo/1.3. > 0-1/autopkgtest > > build result: > > http://debomatic-amd64.debian.net/distribution#unstable/taptempo/1.3. > 0-1/buildlog > > > Should I update this new package to the mentors website? > > Yes, please fix the two problem mentioned above, and upload to > mentors. > > Thank you for you contribution to Debian, and have a good day.
Attachment:
signature.asc
Description: This is a digitally signed message part