Bug#887403: Acknowledgement (RFS: budgie-extras/0.4.0-1)

["foss.freedom" <foss.freedom@gmail.com>]

Hi Herbert,

  no I wasn't aware of that lintian - I ran lintian -i -I --pedantic
on my latest unstable but it didn't highlight that.  Odd.

However I have now corrected that in debian/rules.  I have taken also
the opportunity to refresh the source & build with the very latest
fixes made by the team made in the last month.

https://mentors.debian.net/debian/pool/main/b/budgie-extras/budgie-extras_0.4.2-1.dsc

The changelog has been adjusted slightly to reflect this
DEB_BUILD_OPTIONS addition:

  * New upstream release
  * Packaging Changes:
    - debian/control and debian/compat: update to v11
    - debian/control: Bump Standards-Version - no changes required
    - debian/control: new binary packages budgie-rotation-lock-applet,
      budgie-clockworks-applet,
      budgie-dropby-applet
    - debian/copyright: 2018 year updates
    - debian/rules remove ninja make rules since debhelper can deal
      with meson builds
    - debian/rules check DEB_BUILD_OPTIONS for autotest
    - remove not needed debian/files
    - signing key; move and rename to debian/upstream


thanks

David

On 25 February 2018 at 14:46, Herbert Fortes <terberh@gmail.com> wrote:
> Em 27-01-2018 14:06, foss.freedom escreveu:
>> The team has completed a minor release with lots of useful bug-fixes.
>>
>> These are summarised in the source ChangeLog file
>>
>> dget -x https://mentors.debian.net/debian/pool/main/b/budgie-extras/budgie-extras_0.4.1-1.dsc
>>
>> The debian/changelog I have just changed the package version info -
>> everything else is the same as originally detailed.
>>
>>
>
> Are you aware about this lintian?
>
>
> I: override_dh_auto_test-does-not-check-DEB_BUILD_OPTIONS
> N:
> N:   The debian/rules file for this package has an override_dh_auto_test
> N:   target that does not appear to check DEB_BUILD_OPTIONS against
> N:   nocheck.
> N:
> N:   As this check is not automatically performed by debhelper(1), the
> N:   specified testsuite is run regardless of another maintainer using the
> N:   nocheck build profile.
> N:
> N:   Please add a check such as:
> N:
> N:    override_dh_auto_test:
> N:    ifeq (,$(filter nocheck,$(DEB_BUILD_OPTIONS)))
> N:            ./run-upstream-testsuite
> N:    endif
>
> It is a:
>
> N:   Severity: wishlist, Certainty: wild-guess
>
> Let me know so I can do the upload.
>
>
>
> Regards,
> Herbert