[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Bug#890756: marked as done (RFS: youtube-dl/2018.01.27-1.1 [NMU] -- downloader of videos from YouTube and other sites)

Your message dated Sat, 24 Feb 2018 10:52:56 -0500
with message-id <20180224155256.GA10695@bogus>
and subject line Re: Bug#890756: RFS: youtube-dl/2018.01.27/1.1 [NMU] -- downloader of videos from YouTube and other sites
has caused the Debian Bug report #890756,
regarding RFS: youtube-dl/2018.01.27-1.1 [NMU] -- downloader of videos from YouTube and other sites
to be marked as done.

This means that you claim that the problem has been dealt with.
If this is not the case it is now your responsibility to reopen the
Bug report if necessary, and/or fix the problem forthwith.

(NB: If you are a system administrator and have no idea what this
message is talking about, this may indicate a serious mail system
misconfiguration somewhere. Please contact owner@bugs.debian.org
immediately.)


-- 
890756: https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=890756
Debian Bug Tracking System
Contact owner@bugs.debian.org with problems
--- Begin Message --- 
Package: sponsorship-requests
Severity: normal
Control: block 890119 by -1
Control: tag 890119 + pending
Control: tag -1 + security

Hi,

I'm looking for a sponsor for this NMU against youtube-dl.
It removes youtube-dl's built-in autoupdate mechanism, whose security
is unclear and which is defunct on Debian anyhow (see #890119 for details).

@Rogério: This exactly adds the patch I sent to the packaging repository in
          https://github.com/rbrito/pkg-youtube-dl/pull/2
          However, since the state of the packaging repository is inconsistent
          with what is in the Debian archive, you will need to push to the
          repository, merge my PR, and then manually grab the updated changelog.


The updated version of the package is available on mentors.d.n :

  https://mentors.debian.net/package/youtube-dl
  https://mentors.debian.net/debian/pool/main/y/youtube-dl/youtube-dl_2018.01.27-1.1.dsc


Note that there are 2 minor issues in the package that I did not change:
- The package still uses dh 10
  I have no idea whether the maintainer wants to switch to dh 11
- groff throws a warning on the youtube-dl(1) manpage (lintian tag
  manpage-has-errors-from-man), but I believe this is out of scope for this NMU.


Best,

  nicoo

-- System Information:
Debian Release: buster/sid
  APT prefers testing
  APT policy: (900, 'testing'), (500, 'unstable')
Architecture: amd64 (x86_64)
Foreign Architectures: i386

Kernel: Linux 4.14.0-3-amd64 (SMP w/4 CPU cores)
Locale: LANG=en_US.UTF-8, LC_CTYPE=en_US.UTF-8 (charmap=UTF-8) (ignored: LC_ALL set to en_US.UTF-8), LANGUAGE=en_US.UTF-8 (charmap=UTF-8) (ignored: LC_ALL set to en_US.UTF-8)
Shell: /bin/sh linked to /bin/dash
Init: systemd (via /run/systemd/system)
LSM: AppArmor: enabled

Attachment: signature.asc
Description: PGP signature


--- End Message ---
--- Begin Message --- 
Hi Rogério,

On Sun, Feb 18, 2018 at 08:56:23PM -0300, Rogério Brito wrote:
> Hi, Nicholas.
> 
> There's no need to rush with any upload, as I am going to take care of that
> myself.
> 
> BTW, we had, essentially, a whole week of extended holidays here in Brazil
> during this week (Carnival), which was the reason why I had not replied
> earlier (poor connectivity etc.).

OK, sorry for assuming you might not be around for longer.
Also, sorry for the slow reply, I am myself travelling this week.

I'm closing the RFS as you will take care of it.  :)


> > It removes youtube-dl's built-in autoupdate mechanism, whose security
> > is unclear and which is defunct on Debian anyhow (see #890119 for details).
> 
> I am OK (not super happy, but OK) with the removal of the --upgrade option
> of youtube-dl, *BUT* I think that removing it completely and giving the
> users that try to invoke the command with that option something like "option
> not recognized" is a poor user-experience.

What's making you unhappy with the removal of that code, given that
it is (supposed ot be) defunct on Debian anyhow?


> We should, *IF* we remove the option, substitute it with an output saying
> that in Debian (and other derived distributions) we have disabled that
> option.  Not having this will make users confused, since it would deviate
> from the behavior of upstream.

That's fairly sensible, I will update the patch in the PR.


> > @Rogério: This exactly adds the patch I sent to the packaging repository in
> >           https://github.com/rbrito/pkg-youtube-dl/pull/2
> >           However, since the state of the packaging repository is inconsistent
> >           with what is in the Debian archive, you will need to push to the
> >           repository, merge my PR, and then manually grab the updated changelog.
> 
> Yes, I have not yet taken the time to migrate things to salsa.debian.org. I
> will do as soon as I get familiar with the needed changes.

A migration to salsa should be straightforward, but in the meantime, pushing the
current version to the Github repo would be appreciated :)

> > Note that there are 2 minor issues in the package that I did not change:
> > - The package still uses dh 10
> >   I have no idea whether the maintainer wants to switch to dh 11
> 
> That's on purpose/intentional, to ease backporting for people that don't
> have a debhelper so recent.

OK, I assumed as much  :)


> > - groff throws a warning on the youtube-dl(1) manpage (lintian tag
> >   manpage-has-errors-from-man), but I believe this is out of scope for this NMU.
> 
> This problem has been communicated upstream and we reached the conclusion
> that it is a problem with pandoc...

Thanks for the info.


Best,

  nicoo

--- End Message ---
Reply to: