Bug#886399: RFS: opencascade/7.2.0-1 [ITP]
Hi Kurt,
Just a short review. I did not test the package. But some
stuff should be fixed before it will be uploaded.
As I understand you want to maintain the package under the
umbrella of debian science team? If so, please fix some
corresponding fields (maintaner etc) in d/control.
=====
1. source/include-binaries remove
2. source/options - remove
3. quilt debian/control : quilt - remove
4. VCS - salsa under d/science
5. all lib-packages should be numbered according to its API-version,
something like libopencascade-modeling-algorithms7.2
6. Install files of lib-packages should have something like
usr/lib/*/libTKMath.so.*, not the particular version
7. --parallel option is not needed with debhelper > 10
8. Not sure about option -DCMAKE_BUILD_TYPE=Release.
9. Simplify d/rules. All cp-commands should be replaces by the lines
in d/install-files
10. Check whether you need mkdir-commands in d/rules
11. override_dh_makeshlibs looks questionable
12. Use dh_missing --fail-missing to be sure that all files are installed.
13. Point the first upload into the experimental.
14. Double-check __all__ the files and their licenses to save the time
for FTP-masters.
=====
Also it is important to check whether the package so-installable with
oce. Also all dependent on oce packages should be checked, whether
they can be rebuilt against opencascade. No need to keep two similiar
packages in the archive.
PS I am mostly off this week.
Regards
Anton
2018-02-11 18:36 GMT+01:00 Kurt Kremitzki <kkremitzki@gmail.com>:
> Hello all,
>
> I am still looking for a sponsor for this package. My current work is at
> https://salsa.debian.org/kkremitzki-guest/opencascade.
>
> I have an experimental FreeCAD 0.17 (as well as Netgen 6.2.1801) built against
> this package, and I would greatly like to get them in to Testing, if at all
> possible, in time for the March 1st import freeze for Ubuntu 18.04, so I will
> gladly do whatever work is needed to get these packages into shape if someone
> more senior can point me in the right direction.
>
> Thanks.
>
> On Fri, 05 Jan 2018 05:39:25 -0600 kkremitzki@gmail.com wrote:
>> Package: sponsorship-requests
>> Severity: wishlist
>>
>> Dear mentors,
>>
>> I am looking for a sponsor for my package "opencascade"
>>
>> * Package name : opencascade
>> Version : 7.2.0-1
>> Upstream Author : Open CASCADE S.A.S.
>> * URL : https://www.opencascade.com
>> * License : LGPL 2.1 with OpenCASCADE exception
>> Section : science
>>
>> It builds those binary packages:
>>
>> libopencascade-data-exchange-7.2.0 - Open CASCADE Technology module
>> for CAD data format interoperabili
>> libopencascade-data-exchange-dev - Open CASCADE Technology module for
>> CAD data format interoperabili
>> libopencascade-foundation-7.2.0 - Open CASCADE Technology module
>> underlying all other OCCT classes
>> libopencascade-foundation-dev - Open CASCADE Technology module
>> underlying all other OCCT classes
>> libopencascade-modeling-algorithms-7.2.0 - Open CASCADE Technology
>> module containing vast range of geometric
>> libopencascade-modeling-algorithms-dev - Open CASCADE Technology
>> module containing vast range of geometric
>> libopencascade-modeling-data-7.2.0 - Open CASCADE Technology data
>> structures for 2D/3D geometric primi
>> libopencascade-modeling-data-dev - Open CASCADE Technology data
>> structures for 2D/3D geometric primi
>> libopencascade-ocaf-7.2.0 - Open CASCADE Technology module offering
>> solutions for application
>> libopencascade-ocaf-dev - Open CASCADE Technology module offering
>> solutions for application
>> libopencascade-visualization-7.2.0 - Open CASCADE Technology module
>> providing complex mechanisms for g
>> libopencascade-visualization-dev - Open CASCADE Technology module
>> providing complex mechanisms for g
>> opencascade-draw - Open CASCADE Technology CAE test harness
>> opencascade-misc - Open CASCADE Technology CAE platform shared library
>> miscellaneous
>>
>> To access further information about this package, please visit the
>> following URL:
>>
>> https://mentors.debian.net/package/opencascade
>>
>>
>> Alternatively, one can download the package with dget using this
>> command:
>>
>> dget -x https://mentors.debian.net/debian/pool/main/o/opencascade/ope
>> ncascade_7.2.0-1.dsc
>>
>> More information about opencascade can be obtained from https://www.ope
>> ncascade.com/.
>>
>>
>
Reply to: