Bug#887126: RFS: ddupdate/0.2.0-1 #886546
Hi Alec,
Alec Leamas kirjoitti 04.02.2018 klo 18:32:
> Hi Juhani!
>
> Thanks for your reply, and sorry that I missed it! It was probably lost
> in the noise, was not really prepared for a reply from the bug so to
> speak. Listening to high-volume lists is not always easy :(
Not a problem, and you did reply to my ping quite swiftly!
>> Please use up-to-date lintian. It'll give you an error tag and several
>> informational and pedantic tags, some of which are easily dealt with.
>
> I'm using sid, updated as of current?!
"lintian -EIi --pedantic *.changes" will show the pedantic and info tags
that I mentioned.
The error tag is no longer present in the package :) For the record, it was
E: ddupdate source: build-depends-on-obsolete-package build-depends: dh-systemd => use debhelper (>= 9.20160709)
>> This review is based on the package you have uploaded to mentors, but
> I also
>> had a look at your git repo, where you wrote in a commit message:
>>> debian: Fix Standards-Version: to current sid 4.0.0
>> Your sources for that information are outdated, you should check [1]
> instead.
>
> This one beats me... should I read it that current standard is 4.1.3?
Correct.
> Fixing using the ideas Standards-Version == 4.1.3 and compat level ==
> 11. Still unsure, though.
Standards-Version refers to a version number of Debian Policy
(as specified in policy §4.1 and §5.6.11). The latest version number
of the package debian-policy in sid will indicate the latest Policy
version, as will the online copy at debian.org/doc/debian-policy.
The manpage debhelper(7) is where debhelper's compat levels are documented.
>> debian/rules:
>> Debhelper has picked Makefile instead of setup.py, so you should add
>> "--buildsystem=pybuild" after the --with arguments. Then you can
> remove override_dh_build,
>> override_dh_auto_install and override_dh_python3 rules, and delete the
> file debian/install.
>
> However, this is on purpose. I control upstream, and the Makefile
> actually does the right things. Is there anything wrong with this approach?
>
> That said, rules is in a much better shape since the review, cleaned up
> and with a dh_override_missing added.
Your approach is fine, although you're using "--quiet" while verbose
builds are preferred[1]. Back in 0.2.0 the Makefile didn't contain the
build target and so I thought it was only for pylint etc.
>> The installed package is missing some Depends: "ModuleNotFoundError:
> No module named 'straight'".
>
> Recent dependencies for the .deb package looks ok to me. Note that the
> straight.plugin and sudo deps have been dropped by upstream.
Alright. I think debian/py3dist-overrides is left over and can be deleted.
Regards,
Juhani
[1] https://wiki.debian.org/UpstreamGuide#Verbose_builds
Reply to: