[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Re: packjpg packaging: C++ help needed

Andreas Tille kirjoitti 31.01.2018 klo 14:49:
> Hi,
> I stumbled upon unfinished packaging for packjpg in collab-maint SVN[1].
> I intended to save the current packaging state to Git before SVN will be
> closed down and consiered pkg-phototools a better place than
> collab-maint.  So I updated the packaging to latest upstream and pushed
> the packaging to Git[2].
> When trying to build[2] I stumbled upon
> ...
> g++ -c -o aricoder.o aricoder.cpp -I. -O3 -Wall -pedantic -funroll-loops -ffast-math -fsched-spec-load -fomit-frame-pointer -std=c++14 -DUNIX
> packjpg.cpp: In function 'bool pack_pjg()':
> packjpg.cpp:3312:22: error: 'class Writer' has no member named 'getpos'
>   dev_size = str_out->getpos();^M
> ...
> Unfortunately I have no idea how to fix this.  Any hints?

The compilation succeeds if I modify the patch not to define DEV_INFOS:

$ git diff -U0
diff --git a/debian/patches/dev.patch b/debian/patches/dev.patch
index 02869a1..415ebda 100644
--- a/debian/patches/dev.patch
+++ b/debian/patches/dev.patch
@@ -14 +14 @@ Description: include developer functions
-+#define DEV_INFOS // uncomment to include developer information
++// #define DEV_INFOS // uncomment to include developer information^M

(Afterwards I ran "quilt push -a ; quilt refresh" to clean up the patch.)

With DEV_INFOS defined, packjpg.cpp tries to use member functions that
were removed in https://github.com/packjpg/packJPG/commit/bb72a4e1b.

> Kind regards
>         Andreas.


Reply to: