[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Bug#883627: RFS: network-manager-fortisslvpn/1.2.6-1 [ITP] -- NetworkManager Fortinet SSLVPN plugin



Hi!

On Wed, 17 Jan 2018 14:31:24 +0100 Lubomir Rintel <lkundrak@v3.sk> wrote:
> At 1.2.8 now.
> 
> https://mentors.debian.net/debian/pool/main/n/network-manager-fortisslvpn/network-manager-fortisslvpn_1.2.8-1.dsc

I think the package is already in a pretty good shape. Only a few minor
nits. The other day, I've uploaded gnome-shell 3.26.2-4 to unstable
where I pulled your patches for the libnm port.

I would thus prefer, if network-manager-fortisslvpn does not build the
libnm-glib compat support, as I'm actually in the process of getting all
affected packages updated to drop those dependencies.

Would be great if you apply the attached patch and re-upload 1.2.8-1.
I'm happy to sponsor the package then.

Regards,
Michael

-- 
Why is it that all of the instruments seeking intelligent life in the
universe are pointed away from Earth?
diff --git a/debian/control b/debian/control
index 0993a2e..eff1d16 100644
--- a/debian/control
+++ b/debian/control
@@ -4,15 +4,9 @@ Priority: optional
 Maintainer: Lubomir Rintel <lkundrak@v3.sk>
 Build-Depends: debhelper (>= 11),
                intltool,
-               network-manager-dev (>= 1.2.0),
-               libnm-util-dev (>= 1.2.0),
-               libnm-glib-dev (>= 1.2.0),
-               libnm-glib-vpn-dev (>= 1.2.0),
-               libnm-gtk-dev (>= 1.2.0),
                libnm-dev (>= 1.2.0),
                libnma-dev (>= 1.2.0),
                ppp-dev (>= 2.4.7-1+1),
-               libdbus-glib-1-dev (>= 0.74),
                libsecret-1-dev (>= 0.18),
                libgtk-3-dev (>= 3.4),
                libglib2.0-dev (>= 2.32)
@@ -27,8 +21,6 @@ Depends: ${shlibs:Depends},
          ${misc:Depends},
          network-manager (>= 1.2.0),
          openfortivpn
-Breaks: network-manager-fortisslvpn-gnome (<< 1.2.4-2)
-Replaces: network-manager-fortisslvpn-gnome (<< 1.2.4-2)
 Description: network management framework (Fortinet SSLVPN plugin core)
  NetworkManager is a system network service that manages your network devices
  and connections, attempting to keep active network connectivity when
diff --git a/debian/network-manager-fortisslvpn-gnome.install b/debian/network-manager-fortisslvpn-gnome.install
index 8cbcbe5..c0c7cc6 100644
--- a/debian/network-manager-fortisslvpn-gnome.install
+++ b/debian/network-manager-fortisslvpn-gnome.install
@@ -1,4 +1,3 @@
-usr/lib/*/NetworkManager/libnm-fortisslvpn-properties.so
 usr/lib/*/NetworkManager/libnm-vpn-plugin-fortisslvpn-editor.so
 usr/lib/NetworkManager/nm-fortisslvpn-auth-dialog
 usr/share/appdata/network-manager-fortisslvpn.metainfo.xml
diff --git a/debian/rules b/debian/rules
index b04953f..91a1423 100755
--- a/debian/rules
+++ b/debian/rules
@@ -13,6 +13,7 @@ override_dh_auto_configure:
 	dh_auto_configure -- \
 		--libexecdir=/usr/lib/NetworkManager \
 		--disable-static \
+		--without-libnm-glib \
 		--with-pppd-plugin-dir=$(PPPD_PLUGIN_DIR)
 
 override_dh_makeshlibs:

Attachment: signature.asc
Description: OpenPGP digital signature


Reply to: