[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Bug#878804: RFS: shotwell/0.26.3-1



On Sun, Oct 22, 2017 at 5:08 PM, Ghislain Vaillant <ghisvail@gmail.com> wrote:
> On 22/10/17 21:12, Jeremy Bicha wrote:
>> 3. I'm attaching a patch to fix the install of appstream metadata.
>> You'll also need to modify debian/shotwell.install to install the
>> metadata.
>>
>> --- debian/shotwell.install    2017-09-22 17:26:18.000000000 -0400
>> +++ ../debian/shotwell.install    2017-10-22 15:59:36.667571371 -0400
>> @@ -1,3 +1,4 @@
>>   usr/bin
>>   usr/lib
>>   usr/share/applications
>> +usr/share/appdata
>
>
> From the AppStream guidelines [1], the metadata are to be installed under
> /usr/share/metainfo not /usr/share/appdata. Otherwise, Lintian will trigger
> a warning [2].

That's a warning that in my opinion ought to be fixed upstream instead
of just working around it in the Debian packaging. So I filed

https://bugzilla.gnome.org/790185

There's a new upstream version 0.26.4 which includes the patch I
proposed last month.

But as a workaround for now, if you want to install the metadata to
/usr/share/metainfo/ you can add this to the header in
debian/copyright before using uscan to fetch the new version:

Files-Excluded: m4

And add Build-Depends on autoconf-archive, libglib2.0-dev-bin and
yelp-tools. That should probably be done anyway to avoid code
duplication and ensure we are building with the latest versions of the
autoconf macros.

Thanks,
Jeremy Bicha


Reply to: