Bug#872996: RFS: node-unicode-tr51/9.0.0-1 ITP
control: tags -1 - moreinfo
Hi,
Le 23/08/2017 à 22:05, roucaries bastien a écrit :
> * debian/control:
> + section is javascript
Done.
> + you should use package.json version in source depends
I use the currently available mocha in Debian, as it looks like it's
enough ; apart from this remark : done.
> + Description is too short. Define emoji for instance. What contain
> emoji data ?
Done, hopefully to your satisfaction.
> * copyright:
> please mention in general comment what I have just opened #873028
> for adding emoji to unicode-data
Done.
> * rules
> They are no guarantee that .js file are overwritten by script
> and even in this case your package does not build cleanly. Better is
> to create a debian/build directory (rm -rf during clean) that will get
> a symlink of script and data. Than run script on it.
Done.
> * debian/test/mocha: please you a copy on my runtestsuite script. It
> will use installed version instead of source
Done, but you might still want to check what I did with it :-/
> * debian/watch is 4
Done.
Snark on #debian-js
Reply to: