On Tue, Jul 04, 2017 at 05:35:15PM +1000, Hayden Briese wrote:
I'm not a DD, so can't sponsor your package. Here are some comments:
> * Package name : fancon
> Version : 0.11.13
> Upstream Author : Hayden Briese (haydenbriese@gmail.com)
> * URL : https://github.com/hbriese/fancon
> * License : Apache Version 2.0
> Section : utils
1. The package you created is a native package. This generally is only useful
for software that are specifically targeted for Debian. In this case non-native
would be the better choice. (See [1] for an explanation of native/non-native)
2. The files README and README.source still contain default text, either remove
the files or fill them with useful information.
3. debian/fancon-docs.docs: This file is named wrong. Either name it just
"docs" or "fancon.docs". The part before the ".docs" is the package name it
applies to and you don't build a package named fancon-docs. (See "man
dh_installdocs"). Also, the contents are wrong, the man-page has more
information about that as well.
4. debian/manpage.1: That doesn't look useful at all.
5. debian/copyright: the files under the cmake-directory have different
copyright information, you need to record that as well.
6. debian/rules: Are all the overrides really needed? Then you should document
why they are there and delete the non-used comments.
7. debian/control:
a) Carefully look at the Build-Depends again, some of the packages you
specified are already in build-essential so no need to specify them
again.
b) The current Standards version is 4.0.0
c) Consider running "wrap-and-sort" from devscripts to make the
Depends/Build-Depends more readable
8. The package doesn't build:
In file included from /<<PKGBUILDDIR>>/src/Controller.hpp:4:0,
from /<<PKGBUILDDIR>>/src/main.hpp:4,
from /<<PKGBUILDDIR>>/src/main.cpp:1:
/<<PKGBUILDDIR>>/src/Devices.hpp:18:15: error: 'fancon::FanNV' has not been declared using fancon::FanNV;
/<<PKGBUILDDIR>>/src/Devices.hpp:21:15: error: 'fancon::SensorNV' has not been declared using fancon::SensorNV;
(Full buildlog at https://warperbbs.de/buildlogs/fancon.build)
Cheers,
Andreas
[1] https://wiki.debian.org/DebianMentorsFaq#What_is_the_difference_between_a_native_Debian_package_and_a_non-native_package.3F
--
PGP-encrypted mails preferred
PGP Fingerprint: 74CD D9FE 5BCB FE0D 13EE 8EEA 61F3 4426 74DE 6624
Attachment:
signature.asc
Description: PGP signature