Bug#884143: ITA: urbit/0.5-1 -- an operating function
Control: tags -1 moreinfo
Control: retitle -1 RFS: urbit/0.5-1 -- an operating function
Hi Ted,
(The control line just straights up the bug title and set the "moreinfo
tag, which basically says that you need to refine your package.)
> https://bootstrap.urbit.org/urbit_0.5-1_amd64.upload
You cannot upload to ftp.debian.org: Only project members and DM's can
:)
> https://bootstrap.urbit.org/urbit_0.5-1.dsc
dget'ing the dsc fails with a 403, when it tries to get the orig.tar.gz
May I recommend to utilize mentors.debian.net to store the package for
reviews?
> Changes since the last upload:
>
> urbit (0.5-1) unstable; urgency=medium
> * hoon %143; new boot sequence; %jael support
> -- Ted Blackman <ted@tlon.io> Thu, 12 Oct 2017 17:11:53 -0700
>
> This is my first time submitting a package to debian. I've tried to
follow
> the instructions exactly, but I'm not sure I've gotten them all
right. I'd
> appreciate any advice you're willing to give me as I go though this
process.
Understood, the first package is always the most difficult one :)
The topic is also not the easiest one, especially making a new package
from scatch. So I hand over a bunch of links for you, you likely came
accross them already:
- You should read https://mentors.debian.net/intro-maintainers. There
are many links it which your probably want to skim through, but you
should read the FAQ https://wiki.debian.org/DebianMentorsFaq
- As you seem to be related to upstream, please read the upstream guide
https://wiki.debian.org/UpstreamGuide.
- https://mentors.debian.net/sponsor/rfs-howto
- As the package is new, you need to file an so-called ITP bug against
the package wnpp. See also here: https://www.debian.org/devel/wnpp/
I did not really take a look at the packageing (just a quick glance at
the github repository), but here are a few remarks:
- d/changelog (d/ stands for files in the debian directory), is not for
"upstream" changes, but only for changes made to the packageing. Also,
for the first upload to Debian, it has to be "Initial Upload (Closes:
#ITP-Bug-Number). This also true for the iteration needed to get the
package suitable.
- d/control: When having d/compat at level 10, you must also have a
build-dependency (B-D) on debhelper >= 10.
- d/control: You do not need to B-D g++ and you do B-D on autotools
stuff and CMake?
- d/control: Standard-Version is too old. You need to update it to the
latest and check if any updates on the packaging are required for this.
The "Policy Upgrade Checklist" will be handy for that and will also
make you learn a lot about the Debian Policy ;-)
- URLs should always use the secure versions (e.g https instead of
http).
- (The SSL certificate on https://urbit.org/ does not validate)
- d/debhelper-build-stamp -> should not be in the repo
- d/rules why do you override dh_autoinstall?
- The Makefile overwrites CC, CFLAGS, CXXFLAGS ... Do not do that.
(I would also strongly recommend to use a build system, not a static
Makefile. (Hint: You B-D on CMake and autotools), but of course this is
your (upstream) decission)
- Also, it seems that you have a lots of external libraries in outside.
Please not that Debian Policy is that you must packages versions, you
cannot use embedded code copies. (If dependencies are not in Debian,
they must be packages separately.)
- That means also that most likely your d/copyrihgt is incomplete.
- d/docs: Don't install license.txt. That is d/copyright for.
- Please utilize linitan to check the packages. You can integrate that
into your package build workflow, either using debuild.
But you want to use something like pdebuilder! (https://pbuilder.alioth
.debian.org/)
Please do not hesitate to ask questions and when you think you're ready
for another round of review, please remove the "moreinfo" tag.
--
tobi
Reply to: