[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Bug#883751: RFS: deepin-calculator/1.0.1-1 [ITP]



On Mon, Dec 11, 2017 at 08:25:20AM +0800, Yangfl wrote:
> 2017-12-11 7:26 GMT+08:00 Adam Borowski <kilobyte@angband.pl>:
> > On Thu, Dec 07, 2017 at 04:04:41PM +0800, Yangfl wrote:
> >>  * Package name    : deepin-calculator
> >>    Version         : 1.0.1-1
> >
> >>   It builds those binary packages:
> >>     deepin-calculator - Calculator for deepin
> >
> > Lintian sez:
> > W: deepin-calculator: desktop-entry-lacks-main-category usr/share/applications/deepin-calculator.desktop
> > and indeed, it shows in the menu as "Other".
> >
> > Otherwise, everything seems fine.

> added patches from upstream branch.

The new version has:
missing-license-paragraph-in-dep5-copyright gpl-2+

And indeed -- you only have a section for gpl-3+, but not gpl-2+.


It'd be nice if you could run lintian before requesting an upload -- both of
these issues wouldn't require a round-trip.  Automated tools save human
time...

Obviously, there's no requirement to be entirely lintian clean: it's a
mindless tool that makes errors, but in the vast majority of times it's
worth to at least consider what it says.


喵!
-- 
// If you believe in so-called "intellectual property", please immediately
// cease using counterfeit alphabets.  Instead, contact the nearest temple
// of Amon, whose priests will provide you with scribal services for all
// your writing needs, for Reasonable And Non-Discriminatory prices.


Reply to: