Em ter, 2017-12-05 às 22:05 +0100, Adam Borowski escreveu: > On Tue, Dec 05, 2017 at 02:12:50AM -0200, Carlos Donizete Froes wrote: > > > However, it crashes a lot. > > > > > > For example, try to enable fullscreen -> SIGSEGV. > > > > > > Exit -> SIGABRT: > > > #0 0x00007f4207738a70 in __GI_raise (sig=sig@entry=6) at > > > ../sysdeps/unix/sysv/linux/raise.c:51 > > > #1 0x00007f420773a19a in __GI_abort () at abort.c:89 > > > #2 0x00007f4201b78744 in _dbus_abort () at /lib/x86_64-linux-gnu/libdbus- > > > 1.so.3 > > > ..... > > > > This did not happen on my machine, other than a bug not related to the game, > > but > > from the SDL2 library. > > > > --- > > dbus[18767]: arguments to dbus_connection_unref() were incorrect, assertion > > "connection->generation == _dbus_current_generation" failed in file > > ../../../dbus/dbus-connection.c line 2822. > > This is normally a bug in some application using the D-Bus library. > > This bug reported on bugzilla SDL2, but so far I have not got answers.[1] > > > > [1] - https://bugzilla.libsdl.org/show_bug.cgi?id=3978 > > Oh well, a crash that happens on exit is not a show stopper. It'll pollute > home dirs (if started from .desktop) or wherever you start the game from > (cmdline) for people with a non-zero ulimit -c, but the vast majority does > not set it so. > > Papering it over by calling _exit(0) (with an underscore) yourself is also > an option (note: on glibc, _exit is really exit_group these days). Fixed bug: "arguments to dbus_connection" > > > Autopkgtest that consists of "Test-Command: /bin/true" is not exactly of > > > any > > > use. Please remove that, or replace with an actual test (although I don't > > > see what could be testable this way in a graphical game). > > > > Unfortunately, I have not yet learned to use autopkgtest. After the end of > > "debuild", lintian notifies me to add autopkgtest where I chose to do it > > erroneously to pass. :( > > Using lintian in the pedantic mode includes a bunch of suggestions that > don't apply to every project. You don't need to use autopkgtest, it makes > sense only for packages with a meaningful way to run automated tests. Removed the 'debian/tests' directory. Now, lintian appears: --- Now running lintian... I: jag source: testsuite-autopkgtest-missing Finished running lintian. --- > > > Package short descs are not supposed to be in title case, unless it's an > > > actual title -- "Arcade and Puzzle 2D Game" is not. > > > > It was to be "arcade-puzzle 2D game in which you have to break all the > > target pieces", but it went beyond line 60 of the title. > > I mean, "title case" in English is Capitalizing Every Word Except Articles > in a Phrase That Would Otherwise Be Lowercased Other Than Proper Names. > > Thus, "arcade and puzzle 2D game" would be better. Changed short description in debian/control > > > The man page lists documentation sections as if they were arguments that > > > can be passed to the executable. > > > > The man page in my opinion this is normal showing the details about the > > game. But if you want me to change something in it or you want to change, > > feel free. > > The SYNOPSIS section normally shows command line arguments. Your game > doesn't use those, but you still put something else (a list of sections), > formatted and highlighted to look exactly the way every other man page lists > arguments. This would make people think you run the executable this way, > realizing it's not the case only after reading the prose. > > There's no need for such a list, man pages typically don't have an index. Removed the SYNOPSIS part in 'debian/jag.6' Thanks! -- ⢀⣴⠾⠻⢶⣦⠀ Carlos Donizete Froes [a.k.a coringao] ⣾⠁⢠⠒⠀⣿⡁ - https://wiki.debian.org/coringao ⢿⡄⠘⠷⠚⠋⠀ GPG: 4096R/B638B780 ⠈⠳⣄⠀⠀⠀ 2157 630B D441 A775 BEFF D35F FA63 ADA6 B638 B780
Attachment:
signature.asc
Description: This is a digitally signed message part