[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Bug#879720: RFS: runescape/0.2-1 [QA] -- Multiplayer online game set in a fantasy world



Am Samstag, den 28.10.2017, 21:30 -0200 schrieb Carlos Donizete Froes:
> bts tag 879720 +confirmed
> 
> Em sáb, 2017-10-28 às 10:44 +0200, Tobias Frost escreveu:
> > #866227 - ok now. You might also mark it pending though on the BTS
> 
> Sorry, it's my first time that I'm checking something pending, if I'm
> doing it
> wrong, correct me or let me know how I do it correctly.

no problem; mentors purpose is also to share knowledge. 
To mark a bug "pending", you set the tag "pending"
You should probably read https://www.debian.org/Bugs/Developer
along with https://www.debian.org/Bugs/server-control.
To manipulate the bugs you might find the bts(1) tool useful.
(of course you can do that also when replying to bugs)

> I answered this BTS #866227

> > #879784
> > Looking at the package at mentors, I do not see a change in the
> > package that
> > adresses this. The diff from the last version only changes
> > d/changelog and
> > (whitespace change) to d/runescape.8
> 
> Strange, because I made changes to the date in the "month / year"
> part and
> removed my email from the "author".
> 
> In addition to removing the blanks had in 'd/runescape.6'
> 
> > Looking at the comment / BTS: No, this is not how it should be
> > fixed.
> > Please make a safe temporary directory or at least ensure that it
> > does
> > not exist before you try to create it and bail out with an error if
> > so.
> > You can use your PID or the help of mktemp to do the first.
> > 
> > It is not a valid argument that this behaviour has been the same
> > already
> > in the first version.
> 
> I changed the line with the 'mktemp' command as suggested.

Good!

Sorry for bringing up another issue, but I completly missed that
before: The Debian changelog's purpose is not to document changes made
to upstream code but only to document changes made to the Debian
package. (It is in Debian Policy 4.4)

So in your case those lines should not be d/changelog:

  * Changed icon format and fixed bug in desktop file (Closes:
Bug#866227)
  * Replaced command line to create temporary directory (Closes:
Bug#879784)

Instead of those two lines you would write:
  * New upstream release. (Closes: #866227, #879784)

Please fix this and I'll upload.

--
tobi

> Thanks!
> 


Reply to: