[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Bug#874725: RFS: tz-converter/1.0.1-1



Thank you for the feedback! I see now why I was not able to find these issues. I need to update my current developer box, as it looks to not have the up-to-date toolset. I will look at this, plus the initial notes proved and update this thread in the next week or so.

 

Thanks again!

 

Dave

From: Andrey Rahmatullin
Sent: Sunday, October 22, 2017 11:04 PM
To: マイリノデイヴィッド; 874725@bugs.debian.org
Subject: Re: Bug#874725: RFS: tz-converter/1.0.1-1

 

On Sun, Oct 22, 2017 at 10:38:22PM +0900, マイリノデイヴィッド wrote:

> Hello again,

>

> I made further changes to the current  RFS, and made sure lintian errors have been resolved:

>

> https://mentors.debian.net/package/tz-converter

>

> dave@DESKTOP > lintian tz-converter_1.0.1-1_all.deb

You need to run lintian against the binary .changes.

You also need to run it with -EI --pedantic or make an appropriate

.config/lintian/lintianrc.

 

W: tz-converter changes: orig-tarball-missing-upstream-signature tz-converter_1.0.1.orig.tar.gz

W: tz-converter source: out-of-date-standards-version 3.9.8 (current is 4.1.1)

I: tz-converter source: testsuite-autopkgtest-missing

P: tz-converter: no-upstream-changelog

 

> There was just one Pedantic message I could not fix, and that was

> “no-upstream-changelog”. I think this might be ignored, as I do have the

> “changelog.Debian.gz” built in.

It's fine to ignore it but not because you have changelog.Debian.gz. The

upstream changelog and the Debian changelog are separate things.

 

> Would it be possible to request a further review for this update?

Apart from two Lintian warnings:

 

Please switch to the debhelper compat level 10.

Calling the GPL license "GNU" in d/copyright is wrong, please the correct

short name which is "GPL-2+".

I'd drop empty debian/source/include-binaries.

You probably want to update the years in d/copyright.

Depending on python-dateutil instead of python3-dateutil (via

debian/py3dist-overrides) seems incorrect.

Why do you ship the icons in /usr/share/icons/ AND

/usr/share/tz-converter/icons/?

 

--

WBR, wRAR

 


Reply to: