Bug#868086: RFS: beautify-bash/1.1-1 [ITP]

[Herbert Fortes <terberh@gmail.com>]

Em 25-09-2017 17:16, Andrey Rahmatullin escreveu:
> On Mon, Sep 25, 2017 at 05:07:29PM -0300, Herbert Fortes wrote:
>> The debian/watch file is not working.
> It is working here.
> 

Again, debian/watch is working.

Here are my comments about:

debian/changelog:

 - ITP bug number is correct
 - please run 'dch -r' to update the timestamp

debian/compat:

 - Please use 10 instead of 9

debian/control:

 I test the script on python3 with 5 .sh scripts
and it ran without erros. But the first line is

   #!/usr/bin/env python

 So, I put on Build-Depends only:
 
   Build-Depends: debhelper (>= 10), dh-python, python-all

 Standards-Version: 4.1.0
 
 And after 'Package' entry:

   Architecture: all
   Depends: ${misc:Depends}, ${python:Depends}

debian/rules (only these lines):
 
 #!/usr/bin/make -f

 #export DH_VERBOSE = 1

 %:
	 dh $@ --with python2


 override_dh_installchangelogs:
	 dh_installchangelogs CHANGES

Please note that CHANGES file is been installed as
a changelog file so beautify-bash.docs file can be
removed.


debian/copyright:

 The github page says GPL version 2. As the LICENSE file and
the header in beautify_bash.py script too. But debian/copyright 
only has GPL-3.0+. please fix that.

 The file is pretty detailed, thanks for that. But the first 'Files'
entry only has:

 Files: *
 Copyright: 2017 Mike Mestnik <cheako+apt_repo@mikemestnik.net>
 License: GPL-3.0+

 I do not know if you really saying that your are the owner of
the project now or if you  misundertood with the 'debian/*' part.
The ITP says the upstreams are 	Paul Lutus and Shriram V (they
are in the file). If you are the owner now the homepage should 
point to github, I think. Instead of the previous upstream page.
Or remove this entry.

Some tests in t_todo/ are failing.

These are my considerations.



Regards,
Herbert