[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Bug#861617: RFS: ddcutil/0.8.0-6 [ITP] - control monitor settings



On Thu, Aug 31, 2017 at 06:43:45AM -0400, Sanford Rockowitz wrote:
> > Please run lintian (with -EI --pedantic and against the binary .changes) and review its output.
> After executing pdebuild on buster for distribution buster
You should build your packages on sid and test them on sid.

> W: ddcutil: new-package-should-close-itp-bug
> 
>    Should a mentors upload close the ITP bug?
You don't write a separate changelog entry for a mentors "upload".

> > Please update to the current Standards-Version (you've missed that in the
> > previous review).
> Was at 3.9.8, the highest version recognized by lintian in mentors.   I've
> now changed it to 4.1.0,  the version in the 2017-08-21 policy manual.   Of
> course, this means that no release of lintian I've yet encountered
> recognizes the version.
Yes, the policy version should be used.

> > Vcs-* don't point to the packaging repo.
> Now we come to what I think is a substantive issue.  The Vcs-* entries
> pointed to the upstream repository.   Though it wasn't clear from the policy
> manual, I gather from your comment that the Vcs-* entries need to point to a
> debianized repository. 
The policy says "a publicly accessible repository where the Debian source
package is developed".

> There currently is no such repository. 
Then there should be no Vcs-* fields.

> Trying to support the increasing number of variants for  dpkg and rpm
> packaging in the upstream repository under autotools became an unwieldy
> mess.
Sure, that's why it should be a separate repo or a separate branch (it's
automatical when the package is not the upstream).

> Are tarballs sufficient or is a debianized repo required?   Page
> https://wiki.debian.org/PackagingWithGit#pbuilder describes a process for
> maintaining one.  Is this the proper method?
No repos are required, though they may be useful.


Please remove --with autotools-dev lines from d/rules.
You should not delete all COPYING files in dh_auto_install, especially not
those in the upstream source. If you don't want some files to be packaged,
delete them explicitly with rm(1) and full paths.

-- 
WBR, wRAR

Attachment: signature.asc
Description: PGP signature


Reply to: