[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Bug#869926: RFS: oprofile/1.2.0-1 [ITP]



On Thu, Aug 24, 2017 at 04:45:56PM -0300, Roberto Oliveira wrote:
> > I still see a lot of old junk in debian/control:
> > - did you write that Build-Depends? if no, please write them from scratch,
> >   making sure they are complete and necessary.
> I Checked all the dependencies and now just the required dependencies are
> in control file.
dh-autoreconf is not needed and lintian tells that.
libtool and g++ are already pulled by build-essential and debhelper.
g++ (>>3.3.1) is always true for many years.
Are you sure zlib1g-dev is needed? The packages don't depend on zlib.

> > Is libjvmti_oprofile intended to be a public shared library? It looks like
> > a plugin.
> Yes, it is a plugin, I moved it to the correct location.
If both libs are not public shared libs you shouldn't package them as if
they are. This includes .symbols, development files, the package names etc.

Why do you create the user with --home /var/lib/oprofile --no-create-home?
Does it need the home dir or no? What is /var/lib/oprofile?
--with autoreconf is the default with debhelper 10.
Why does oprofile depend on libopagent1?

-- 
WBR, wRAR

Attachment: signature.asc
Description: PGP signature


Reply to: